Add Korean translation #2685

ghost · 2022-07-01T18:08:41Z

Short description of changes

This is creating translation_ko_KR.ts file for Korean.

CHANGELOG: Translation: Added Korean translation to Jamulus

Context: Fixes an issue?

#2653

Does this change need documentation? What needs to be documented and how?

No

Status of this Pull Request

Ready for testing

What is missing until this pull request can be merged?
Testing

Checklist

I've verified that this Pull Request follows the general code principles
I tested my code and it does what I want
My code follows the style guide
I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
I've filled all the content above

ann0see · 2022-07-03T09:33:20Z

Hi! Great and big thanks for the translation. Around Line 108 there is a syntax error. You need to close the message tag there: </message>.
I'm not sure if we need to add anything to Jamulus.pro, but probably yes.

Did you already read https://github.com/jamulussoftware/jamulus/blob/master/docs/TRANSLATING.md?

ghost · 2022-07-03T11:25:18Z

OK, Thanks.

src/translation/translation_ko_KR.ts

ignotus666 · 2022-07-03T14:19:19Z

Ok, no more errors ;) I can't comment on the Korean though...

ann0see · 2022-07-03T19:09:21Z

Yes. That's probably up to the other Korean translator(s).
Next steps here:

Add Korean translation to Jamulus.pro if needed (done)
Get the compiled version from the checks tab and test if the Korean translation shows up correctly (done)
Add involved translators to the translators tab in the app
Add translators to GitHub organisation
Add invite to DC/Matrix

ignotus666 · 2022-07-04T09:26:48Z

@bagjunggyu I just opened your .ts file in QtLinguist and it shows a lot of untranslated strings, when they are actually translated. This is because the type="unfinished" tag is still there (it should be removed). Again, this is due to editing the file directly

ghost · 2022-07-04T10:35:10Z

@ignotus666 Yeah, That was my question #2683
OK, I shall do it right now. and Commit again soon.

ann0see · 2022-07-04T15:27:13Z

Ok. Compiled and included all the necessary files in Jamulus.pro and the qrc file in src. Now there's an error (to me unreadable):

QString::arg: 1 argument(s) missing in 왼쪽 및 오른쪽 로컬 오디오 채널 사이의 레벨을 적절하게 제어합니다. 모노 신호의 경우 두 채널 사이의 팬 역할을 합니다. 예를 들어 마이크가 오른쪽 입력 채널에 연결되어 있고 악기가 마이크보다 훨씬 큰 왼쪽 입력 채널에 연결된 경우 페이더 위의 레이블이 %1을 표시하는 방향으로 오디오 페이더를 이동합니다. 여기서 % 2는 현재 감쇠 표시기입니다.

ghost · 2022-07-04T15:31:08Z

@ann0see That line is
message
location filename="../clientsettingsdlg.cpp" line="59"/
source
Controls the relative levels of the left and right local audio channels. For a mono signal it acts as a pan between the two channels. For example, if a microphone is connected to the right input channel and an instrument is connected to the left input channel which is much louder than the microphone, move the audio fader in a direction where the label above the fader shows %1, where %2 is the current attenuation indicator.
/source
translation
왼쪽 및 오른쪽 로컬 오디오 채널 사이의 레벨을 적절하게 제어합니다. 모노 신호의 경우 두 채널 사이의 팬 역할을 합니다. 예를 들어 마이크가 오른쪽 입력 채널에 연결되어 있고 악기가 마이크보다 훨씬 큰 왼쪽 입력 채널에 연결된 경우 페이더 위의 레이블이 %1을 표시하는 방향으로 오디오 페이더를 이동합니다. 여기서 % 2는 현재 감쇠 표시기입니다.
/translation
/message

ann0see · 2022-07-04T15:32:31Z

Ok. Wait a moment, I've just added my additions to your branch

ann0see · 2022-07-04T15:33:20Z

Ok. I think now I understand what the problem is: You added a wrong space at this line between % and 2

ghost · 2022-07-04T15:34:11Z

OK, I understand it.

ann0see · 2022-07-04T15:41:19Z

Ok. Just checked it on Debian and it compiles and seems to run. Nevertheless: In around 30 to 45 minutes GitHub should be finished and you should check the compiled app from the Checks tab. Some things don't seem to be translated yet, but that's ok

ghost · 2022-07-04T16:35:59Z

@ann0see
I think it should be "src/translation/translation_ko_Kr.qm" changed to "src/translation/translation_ko_KR.qm" in f4176b2

ann0see · 2022-07-04T16:51:48Z

Eh. Yes. You should be able to change that too. (Only on my phone at the moment)

ann0see · 2022-07-04T19:46:20Z

Ok. Can you please now check the app if everything looks ok?

ghost · 2022-07-05T03:11:30Z

It looks Good!

ghost · 2022-07-05T06:00:08Z

I'm awating other user and musicians feedback now.
If it is OK for them, Let me tell you.
but, for me? it's OK now, good to go.

ghost · 2022-07-05T06:52:57Z

Just edited by accepting feedback from Korean users and,
It is their (one of users) actual running image of Jamulus through Win 11

ghost · 2022-07-05T07:01:54Z

Now, I edited all.
This is the end.
Thank you all of you :)

ann0see · 2022-07-05T10:33:06Z

Great!

To merger: this should be squash merged.

ghost · 2022-07-06T04:07:14Z

@pljones Should I affect it here as well?
#2710
#2695

line 737 source and translation to "Now a directory"
line 648 source and translation to "Directory server list full"

pljones · 2022-07-06T06:09:44Z

@pljones Should I affect it here as well?

Thanks, yes. Can you refresh your master from upstream, rebase and take the necessary steps, please.

ghost · 2022-07-06T07:22:24Z

yes sure,
It's done and Is it OK now?

* Translation: Add Korean translation to Jamulus.pro

ann0see · 2022-07-06T17:51:06Z

I've now rebased and pushed it. Let's hope I pushed the correct version

gilgongo · 2022-07-06T17:55:57Z

Hi @bagjunggyu - thanks for contributing! We'd like to invite you to our Discord/Matrix channel where we coordinate releases and discuss details on things like translation.

If you want, please send an email to team@jamulus.io and request an invite. Thanks!

ann0see · 2022-07-06T17:59:00Z

@gilgongo I already asked:

#2685 (comment)
However, we should still add him to the translators group on GitHub probably?

ghost · 2022-07-06T18:15:47Z

Thank you very much all of you.
Actually, I'm not a developer like you guys, until now to me, github was just a memo pad :)
I'm trying to rebase as following this manual

*git remote add upstream git@github.com:jamulussoftware/jamulus ;# add the main repo as upstream remote if you didn’t already as mentioned above
*git fetch upstream ; # Get the latest changes from the main upstream repo you added before (if needed)
*git checkout <theBranchYourWorkIsOn = "patch-1" in this case right?> ;# switch to (= checkout) the branch you want to rebase
*git rebase upstream/master ;# replay (=rebase) your changes onto the latest code (and fix conflicts if needed)
*git rebase --continue # to continue the rebasing progress after having fixed the conflicts
*git push --force # Push the changes to your repo. Be aware that this will overwrite your remote branch!

is it right?

ghost · 2022-07-06T18:17:22Z

@gilgongo Anyway, Thank you very much for your kind inviting me :)

Add Jung-Kyu Park(bagjunggyu) as Korean translator.

pljones · 2022-07-06T18:30:19Z

git remote add upstream [git@github.com](mailto:git@github.com):jamulussoftware/jamulus ;# add the main repo as upstream remote if you didn’t already as mentioned above

As it notes, you do this only once. You then have "origin" as your github repo and "upstream" as the main Jamulus repo.

git fetch upstream ; # Get the latest changes from the main upstream repo you added before (if needed)

This should say git pull upstream master.

git checkout <theBranchYourWorkIsOn = "patch-1" in this case right?> ;# switch to (= checkout) the branch you want to rebase

Yes.

git rebase upstream/master ;# replay (=rebase) your changes onto the latest code (and fix conflicts if needed)

No - don't rebase onto upstream/master ever! It's a moving target. Always do git rebase -i master and check that the commits you see are the commits you've made and nothing else that you didn't do on your branch.

git rebase --continue # to continue the rebasing progress after having fixed the conflicts

Only if you got conflicts, of course.

Now, as an additional check, before the last step:

git diff master

and review your change to make sure it contains everything you want and nothing you do not want.

Finally:

git push --force # Push the changes to your repo. Be aware that this will overwrite your remote branch!

This tells Github you've changed your branch content. Normally --force isn't wanted, as "rewriting history" is bad... usually. But when doing a rebase, it's essential.

Add Jung-Kyu Park(bagjunggyu) as Korean translator.

ann0see · 2022-07-06T18:47:07Z

src/util.cpp

@@ -729,14 +729,15 @@ CAboutDlg::CAboutDlg ( QWidget* parent ) : CBaseDlg ( parent )
                              "<p><b>" +
                              tr ( "Slovak" ) +
                              "</b></p>"
-                              "<p>Jose Riha (<a href=\"https://github.com/jose1711\">jose1711</a>)</p>" +
-                              "<p><b>" + tr ( "Simplified Chinese" ) +
+                              "<p>Jose Riha (<a href=\"https://github.com/jose1711\">jose1711</a>)</p>"


This was almost correct. You need to add yourself without a "+" similar to the translators above.

Thanks :) I would try again.

Add Jung-Kyu Park(bagjunggyu) as Korean translator.

ghost · 2022-07-06T18:54:07Z

@pljones
Should I do command "s" for squash after "git rebase -i master" ?

ghost · 2022-07-06T19:06:03Z

@ann0see It means already rebased? and nothing left to do?

ann0see · 2022-07-06T19:07:12Z

You still need to squash, yes ;-).

ann0see · 2022-07-06T19:48:46Z

I think it's ok like this (we can squash merge it).

There's still some internal stuff we need to do (add to create translation issues) but otherwise: ready for final review

ghost · 2022-07-06T20:07:00Z

@ann0see
Thank you :)
(actually, until now I have failed "git push --force" several times.)

pljones · 2022-07-06T20:27:18Z

Approving despite my utter lack of Korean! Thanks!

ghost · 2022-07-06T20:49:53Z

@pljones Thank you very much :)

ann0see added this to the Release 3.9.0 milestone Jul 2, 2022

ann0see assigned ignotus666 Jul 3, 2022

ignotus666 reviewed Jul 3, 2022

View reviewed changes

src/translation/translation_ko_KR.ts Outdated Show resolved Hide resolved

ignotus666 reviewed Jul 3, 2022

View reviewed changes

src/translation/translation_ko_KR.ts Outdated Show resolved Hide resolved

ann0see changed the title ~~Create translation_ko_KR.ts~~ Add Korean translation Jul 4, 2022

Translation: Add Korean app translation

5572a64

* Translation: Add Korean translation to Jamulus.pro

Update util.cpp

b5812ef

Add Jung-Kyu Park(bagjunggyu) as Korean translator.

Jung-Kyu Park added 2 commits July 7, 2022 03:32

Update util.cpp

21baef7

Add Jung-Kyu Park(bagjunggyu) as Korean translator.

Update util.cpp

fa50190

ann0see reviewed Jul 6, 2022

View reviewed changes

Update util.cpp

0520daf

Add Jung-Kyu Park(bagjunggyu) as Korean translator.

This comment was marked as duplicate.

Sign in to view

pljones approved these changes Jul 6, 2022

View reviewed changes

ann0see approved these changes Jul 6, 2022

View reviewed changes

ann0see merged commit 852c7f5 into jamulussoftware:master Jul 6, 2022

ann0see added the needs documentation PRs requiring documentation changes or additions label Jul 6, 2022

ghost deleted the patch-1 branch July 6, 2022 21:35

ann0see removed the needs documentation PRs requiring documentation changes or additions label Jul 6, 2022

hoffie mentioned this pull request Jul 19, 2022

Translations: Add Korean to language selection #2741

Merged

5 tasks

pljones mentioned this pull request Jul 23, 2022

Prepare Release 3.9.0 #2603

Closed

75 tasks

Add Korean translation #2685

Add Korean translation #2685

Conversation

ghost commented Jul 1, 2022 • edited by ghost Loading

Checklist

ann0see commented Jul 3, 2022

ghost commented Jul 3, 2022

ignotus666 commented Jul 3, 2022

ann0see commented Jul 3, 2022 • edited Loading

ignotus666 commented Jul 4, 2022

ghost commented Jul 4, 2022

ann0see commented Jul 4, 2022

ghost commented Jul 4, 2022 • edited by ghost Loading

ann0see commented Jul 4, 2022

ann0see commented Jul 4, 2022

ghost commented Jul 4, 2022

ann0see commented Jul 4, 2022 • edited Loading

ghost commented Jul 4, 2022 • edited by ghost Loading

ann0see commented Jul 4, 2022

ann0see commented Jul 4, 2022

ghost commented Jul 5, 2022 • edited by ghost Loading

ghost commented Jul 5, 2022

ghost commented Jul 5, 2022 • edited by ghost Loading

ghost commented Jul 5, 2022

ann0see commented Jul 5, 2022

ghost commented Jul 6, 2022

pljones commented Jul 6, 2022

ghost commented Jul 6, 2022

ann0see commented Jul 6, 2022

gilgongo commented Jul 6, 2022

ann0see commented Jul 6, 2022

ghost commented Jul 6, 2022 • edited by ghost Loading

ghost commented Jul 6, 2022

pljones commented Jul 6, 2022

ann0see Jul 6, 2022

Choose a reason for hiding this comment

ghost Jul 6, 2022

Choose a reason for hiding this comment

ghost commented Jul 6, 2022 • edited by ghost Loading

ghost commented Jul 6, 2022

This comment was marked as duplicate.

ann0see commented Jul 6, 2022 • edited Loading

ann0see commented Jul 6, 2022 • edited Loading

ghost commented Jul 6, 2022

pljones commented Jul 6, 2022

ghost commented Jul 6, 2022

ghost commented Jul 1, 2022 •

edited by ghost

Loading

ann0see commented Jul 3, 2022 •

edited

Loading

ghost commented Jul 4, 2022 •

edited by ghost

Loading

ann0see commented Jul 4, 2022 •

edited

Loading

ghost commented Jul 4, 2022 •

edited by ghost

Loading

ghost commented Jul 5, 2022 •

edited by ghost

Loading

ghost commented Jul 5, 2022 •

edited by ghost

Loading

ghost commented Jul 6, 2022 •

edited by ghost

Loading

ghost commented Jul 6, 2022 •

edited by ghost

Loading

ann0see commented Jul 6, 2022 •

edited

Loading

ann0see commented Jul 6, 2022 •

edited

Loading