Translations: Add Korean to language selection

[hoffie]

Short description of changes

• Translations: Make ko-KR (Korean) selectable
• Jamulus.pro: Add reminder for new translations (qrc)

CHANGELOG: Translation: Added Korean translation to Jamulus

Context: Fixes an issue?

Fixes: #2740 #2714
Related: #2685

Does this change need documentation? What needs to be documented and how?

Status of this Pull Request

Ready.

What is missing until this pull request can be merged?

Reviews.

@bagjunggyu Could you check the release artifacts from this PR?

Checklist

• I've verified that this Pull Request follows the general code principles
• I tested my code and it does what I want
• My code follows the style guide
• I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
• I've filled all the content above

[ghost]

Surely!
Let me check this out with other users.
Thank you :)

[ann0see]

Looks good. However waiting for test by @bagjunggyu

[ann0see]

Strange. I thought I did that... nevertheless thanks.

[ghost]

I don't have any idea for build issue though.

If it is OK with 3.8.2dev win.exe file done by auto build several hours ago.

I've got message from Korean user and it is affected well as this image.

it has affected well!
Thank you :)

[hoffie]

@bagjunggyu Thanks for confirming!
The autobuild failure (Windows) is unrelated and is caused by flakiness of one of the dependency downloads. The test with the older build is fine, I've just force-pushed ~2 hours ago due to a whitespace issue in the XML file.

[pljones]

@hoffie @ann0see Is there a guide on adding a new translation and does it include this step?

[ann0see]

I don't think we have a guide. Tony or Ignotus might have written something up, but I doubt it.

[pljones]

Given we've just done it for Korean, it might be worth writing one now before the memories fade away.

[hoffie]

Given we've just done it for Korean, it might be worth writing one now before the memories fade away.

Certainly. I just don't have the energy to push that forward atm, which is why I chose to add at least a small reminder/comment to avoid forgetting this very step in the future. A proper checklist would obviously be even better.

@pljones Feel free to merge on approval.

[ghost]

It was my foot step.
I hope it might help you.

Jamulus Internationalization
ex) Adding Korean

Translator's

• kr.nsi
• installerlng.nsi
• translation_ko_KR.ts
• util.cpp

Dev team's

• resources.qrc
• Jamulus.pro
• translation_ko_KR.qm
• Jamulus Translator Organization

[ann0see]

@bagjunggyu can you edit The TRANSLATION.md file in the docs/ folder and write up a short paragraph what needs to be done (you can pair up with @gilgongo (our "documentation guy")