Make connect dialog show up as fullscreen on iOS #3343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ann0see
added a commit
to ann0see/jamulus
that referenced
this pull request
Aug 7, 2024
Fixes an overflow bug for the about dialog on iOS. Related to: jamulussoftware#3343
5 tasks
ann0see
added a commit
to ann0see/jamulus
that referenced
this pull request
Aug 7, 2024
Fixes an overflow bug for the about dialog on iOS. Related to: jamulussoftware#3343
ann0see
force-pushed
the
iOS/fixOverflowConnectdlg
branch
from
6db711e to
2e8dd33
Compare
ann0see
changed the title
ann0see
added
Mobile UI
|
The chat dialog probably also needs this. |
ann0see
added a commit
to ann0see/jamulus
that referenced
this pull request
Aug 24, 2024
Fixes an overflow bug for the about dialog on iOS. Related to: jamulussoftware#3343
ann0see
force-pushed
the
iOS/fixOverflowConnectdlg
branch
2 times, most recently
from
e623992 to
c93a637
Compare
ann0see
added a commit
to ann0see/jamulus
that referenced
this pull request
Aug 24, 2024
Fixes an overflow bug for the about dialog on iOS. Related to: jamulussoftware#3343
ann0see
added a commit
to ann0see/jamulus
that referenced
this pull request
Sep 22, 2024
Fixes an overflow bug for the about dialog on iOS. Related to: jamulussoftware#3343
Fixes GUI issue of connect dialog overflowing screen on iOS
ann0see
force-pushed
the
iOS/fixOverflowConnectdlg
branch
from
c93a637 to
40e5af1
Compare
|
Looks like the Connect Dialog list entries also need some work to be compatible with a dark mode theme. I suspect those texts are set specifically to black instead of being left to default. |
ann0see
added a commit
to ann0see/jamulus
that referenced
this pull request
Oct 2, 2024
Fixes an overflow bug for the about dialog on iOS. Related to: jamulussoftware#3343
ann0see
added a commit
to ann0see/jamulus
that referenced
this pull request
Oct 2, 2024
Fixes an overflow bug for the about dialog on iOS. Related to: jamulussoftware#3343
|
@pljones Probably you can't test this. A review would still be good. |
ann0see
added a commit
to ann0see/jamulus
that referenced
this pull request
Oct 3, 2024
Fixes an overflow bug for the about dialog on iOS. Related to: jamulussoftware#3343
|
Might be the weekend before I can test it but it looks like it shouldn't cause problems. |
pljones
approved these changes
Oct 3, 2024
5 tasks
ann0see
added a commit
to ann0see/jamulus
that referenced
this pull request
Oct 3, 2024
Fixes an overflow bug for the about dialog on iOS. Related to: jamulussoftware#3343
ann0see
added a commit
to ann0see/jamulus
that referenced
this pull request
Oct 3, 2024
Fixes an overflow bug for the about dialog on iOS. Related to: jamulussoftware#3343
ann0see
added a commit
to ann0see/jamulus
that referenced
this pull request
Oct 3, 2024
Fixes an overflow bug for the chat dialog on iOS. Related to: jamulussoftware#3343
|
BlissOS Android test is ok. |
|
OK, that appears to work for me (moto g(9) power, Android 11) |
ann0see
added a commit
to ann0see/jamulus
that referenced
this pull request
Dec 28, 2024
Fixes an overflow bug for the chat dialog on iOS. Related to: jamulussoftware#3343
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes
Makes Connect dialog show up in full screen like Android if Qt6 is used. This fixes a severe UI issue on the Qt6 build of Jamulus for iOS which didn't allow to even tap the connect button. Now the connect dialog looks like this in dark mode: (broken styling but usable)
CHANGELOG: iOS: Fixed GUI issue preventing the connect dialog to show correctly
Context: Fixes an issue?
Related to issues mentioned in #2711
Does this change need documentation? What needs to be documented and how?
No
Status of this Pull Request
Works based on local build. Didn't test IPA built by GitHub - but this still uses Qt5
What is missing until this pull request can be merged?
Nothing
Checklist