Make about chat show up as fullscreen on iOS #3397
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ann0see
force-pushed
the
iOS/ChatDlgFullscreen
branch
2 times, most recently
from
917881b
to
a4450b8
Compare
Fixes an overflow bug for the chat dialog on iOS. Related to: jamulussoftware#3343
ann0see
force-pushed
the
iOS/ChatDlgFullscreen
branch
from
a4450b8
to
0182e7e
Compare
|
BlissOS Android seems ok too. |
|
This doesn't seem to be enough. In general, the chat window seems very buggy on iOS with Qt6. The aspect ratio is off and tapping on close hangs he app. Not sure how to continue here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an overflow bug for the about dialog on iOS.
Related to: #3343
Short description of changes
Attempt to show chat dialog as full screen. Doesn't work yet - especially if rotating the screen.
CHANGELOG: CONDENSE WITH #3343
Context: Fixes an issue?
Fixes: #3383
Does this change need documentation? What needs to be documented and how?
No
Status of this Pull Request
To be tested. Unfortunately, also the close button on the chat on iOS crashes the application. I think this was documented somewhere and is probably due to a null pointer de-reference.
What is missing until this pull request can be merged?
Not sure
Checklist