Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix connection error handling PR #2

Open
wants to merge 82 commits into
base: master
Choose a base branch
from

Conversation

olcar
Copy link

@olcar olcar commented Jan 16, 2016

  • merged latest changes from orbotix/sphero.js master
  • fixed indentation issues

But still failing 2 tests...

$ grunt
Running "lint" task

lib/adaptors/ble.js
  160:31  warning  Too many nested callbacks (4). Maximum allowed is 3  max-nested-callbacks
  162:23  warning  Too many nested callbacks (5). Maximum allowed is 3  max-nested-callbacks
  167:25  warning  Too many nested callbacks (5). Maximum allowed is 3  max-nested-callbacks
  408:0   warning  Line 408 exceeds the maximum line length of 80       max-len

lib/adaptors/serialport.js
  26:0  warning  Line 26 exceeds the maximum line length of 80  max-len

spec/lib/packet.spec.js
  685:0  warning  Line 685 exceeds the maximum line length of 80  max-len

✖ 6 problems (0 errors, 6 warnings)

Running "test" task


  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․

  271 passing (665ms)
  1 pending
  2 failing

  1) Serialport Adaptor #open "before each" hook:
     TypeError: port.open is not a function
      at Adaptor.open (lib/adaptors/serialport.js:61:8)
      at Context.<anonymous> (spec/lib/adaptors/serialport.spec.js:41:15)

  2) Core commands #getPowerState calls #command with params:
     AssertionError: expected command to have been called with arguments 0, 32, null, function spy() {}
    command(0, 32, null, function () {})
      at Context.<anonymous> (spec/lib/devices/core.spec.js:66:34)



Warning: Task "test" failed. Use --force to continue.

Aborted due to warnings.

jamuus and others added 30 commits October 23, 2015 10:11
Updates Readme

updates Location example
add signed type to parser and use for locator
Zac Colley and others added 29 commits January 2, 2016 23:27
'black' was coming back falsey and coming back as invalid
Need to install both  and  for tests to run correctly
…nstallation-instruction

Added additonal dependancy instructions for development README
This reverts commit 384bd9e.
add collision configuration presets for bb8 device
…, and do not require Noble a second time when this happens
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants