forked from sphero-inc/sphero.js
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix connection error handling PR #2
Open
olcar
wants to merge
82
commits into
jamuus:master
Choose a base branch
from
olcar:fix-connection-error-handling-PR
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…command responses
Updates Readme updates Location example
Use port as env variable in examples
add signed type to parser and use for locator
'black' was coming back falsey and coming back as invalid
Need to install both and for tests to run correctly
…nstallation-instruction Added additonal dependancy instructions for development README
Small wording tweaks
Better named colour check - Fixes sphero-inc#24
This reverts commit 384bd9e.
add collision configuration presets for bb8 device
…, and do not require Noble a second time when this happens
Looks good. Merged.
…t is all you need anyhow
…services-characteristics LGTM. Merged.
…/olcar/sphero.js into fix-connection-error-handling-PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But still failing 2 tests...