Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser console error: tabMainProtocolMap.get(...) is undefined #45

Open
johnp opened this issue Jun 2, 2020 · 2 comments
Open

Browser console error: tabMainProtocolMap.get(...) is undefined #45

johnp opened this issue Jun 2, 2020 · 2 comments

Comments

@johnp
Copy link

johnp commented Jun 2, 2020

The extension frequently causes the following error to be displayed in the browser console:

20:13:31.782 can't access property "protocolVersion", tabMainProtocolMap.get(...) is undefined 2 background.js:54
    loadSavedSecurityInfoAndUpdateIcon moz-extension://18647e97-ca2d-4bbb-979a-557087b95623/background.js:54
    apply self-hosted:1870
    applySafeWithoutClone resource://gre/modules/ExtensionCommon.jsm:614
    fire resource://gre/modules/ExtensionChild.jsm:775
    recvRunListener resource://gre/modules/ExtensionChild.jsm:779
    recvRunListener self-hosted:844
    _recv resource://gre/modules/ConduitsChild.jsm:78
    receiveMessage resource://gre/modules/ConduitsChild.jsm:169
    run resource://gre/modules/ConduitsChild.jsm:160
    receiveMessage resource://gre/modules/ConduitsChild.jsm:161
    map self-hosted:240
    receiveMessage resource://gre/modules/ConduitsChild.jsm:161

This happens on Firefox Nightly with, among other things, fission enabled.

Most likely broken by ea5d372ef0d1620097457134fb6312c9d2f4cc91:

 async function loadSavedSecurityInfoAndUpdateIcon(details) {
-    cached_version = tabMainProtocolMap.get(details.tabId);
+    cached_version = tabMainProtocolMap.get(details.tabId).protocolVersion;
     if (typeof cached_version !== "undefined" && cached_version !== "unknown") {
@Radagast
Copy link

Radagast commented Jun 9, 2020

Confirming this on Nightly.

@jannispinter
Copy link
Owner

Thank you for reporting this, I've just committed a change that should fix the problem.

@ashucg ashucg mentioned this issue Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants