Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements #43

Merged
merged 6 commits into from
Jul 14, 2020
Merged

Enhancements #43

merged 6 commits into from
Jul 14, 2020

Conversation

ashucg
Copy link
Contributor

@ashucg ashucg commented May 8, 2020

All colors are now moved to CSS, classes are updated using JS to allow using different colors for light and dark modes. Updated colors also have better readability because of better contrast ratio. Changes are mostly made for dark theme.

Current popup

image
image

Updated popup

image
image

Icons

Updated font is easier to read (at least for me):

image

@d7415
Copy link

d7415 commented May 9, 2020

I actually prefer the old font face, and I'm not convinced about making the links black - perhaps a darker blue?

The darker text on the 1.2 badge is definitely clearer though. 👍

@ashucg
Copy link
Contributor Author

ashucg commented May 9, 2020

Thanks for the feedback. Actually blue over green, orange or red doesn't result in decent contrast ratio (https://contrastchecker.com/) If you have any particular color scheme that looks good and has good accessibility, please share it.

As for the font face, I understand what you mean. Fonts can be really tricky and depends a lot on user preference. It was just an idea I wanted to share because the updated font looked much better and cleaner to me while I was trying it out.

@rugk
Copy link
Contributor

rugk commented May 9, 2020

I quite like the update.

@d7415
Copy link

d7415 commented May 9, 2020

Thanks for the feedback. Actually blue over green, orange or red doesn't result in decent contrast ratio (https://contrastchecker.com/) If you have any particular color scheme that looks good and has good accessibility, please share it.

Fair point. I'd almost be tempted to lose the cell background for that column and keep it looking different from the rest, but that's probably more controversial than black text!

@ashucg
Copy link
Contributor Author

ashucg commented May 9, 2020

Fair point. I'd almost be tempted to lose the cell background for that column and keep it looking different from the rest, but that's probably more controversial than black text!

Yes, I wanted to change background colors as well. But that might not be liked by a lot of users - that's why I decided to try using black color and get some feedback. Another possibile option is to use a greenish/reddish/orangish white for the last column but I haven't tried it yet so I'm not sure how it would look. But it is something that can be tried and since I have already moved to colors to CSS, it is very simple to do so. I will try to share screenshots when I work on it (hopefully tonight)

No longer using #000 for anchor(s) in resources table. Also changed tab background and foreground colors.
@ashucg
Copy link
Contributor Author

ashucg commented May 22, 2020

Normal / Light

image

Dark

image

P.S.: I have used red for last row just to see how it would like.

@ashucg
Copy link
Contributor Author

ashucg commented Jul 13, 2020

@jannispinter You missed typeof operator in your previous commit to fix #45 and I have changed the code a little, that's the only conflict in the updated code. If you want I can submit a separate pull request for it.

@jannispinter jannispinter merged commit 3ca81e9 into jannispinter:master Jul 14, 2020
@jannispinter
Copy link
Owner

Excellent, thank you so much for your work 👍

I've merged this.

@jannispinter
Copy link
Owner

Sorry that it took so long, I'm going to test the new version and if everything is good, release it as v0.3 today. 🚀

@ashucg
Copy link
Contributor Author

ashucg commented Jul 14, 2020

no problem! let me know if you find any issues.

@andreldmonteiro
Copy link

Please revert the icons, I find them now quite ugly.

@532910
Copy link

532910 commented Jul 16, 2020

strike-outs look ugly
bold font looks ugly

@ashucg
Copy link
Contributor Author

ashucg commented Jul 21, 2020

please let me know if you have any particular font in mind - which looks good and is easy to read.

@ashucg
Copy link
Contributor Author

ashucg commented Jul 21, 2020

Noto Serif might look good. I can try this font instead but would like to get other recommendations as well.

@532910
Copy link

532910 commented Jul 21, 2020

strike-outs are inaccurate and get out of the background

@532910
Copy link

532910 commented Jul 21, 2020

red strikeout on red background looks bad

@andreldmonteiro
Copy link

I liked the icons more in the beginning when they were simpler and TLS 1.2 was green

@532910
Copy link

532910 commented Jul 23, 2020

Subpixel rendering looks blurry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants