Skip to content

Commit

Permalink
(fix): revert #130's breaking change of tsconfig options (#415)
Browse files Browse the repository at this point in the history
- not sure why this change was made in that PR as it was unrelated to
  the rest, but it broke some things related to Babel usage and maybe
  other things
  - e.g. babel macros were not included per #413
  - and it used `tslib` instead of adding babel helper functions

- add a comment of why it seems like the target is overriden to esnext
  - though I am not sure of the original reasoning, as it has existed
    since very early versions of TSDX, see #130 comments
  • Loading branch information
agilgur5 authored and jaredpalmer committed Jan 5, 2020
1 parent ea124bc commit 00f80ac
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion src/createRollupConfig.ts
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,12 @@ export async function createRollupConfig(
sourceMap: true,
declaration: true,
jsx: 'react',
target: 'es5',
},
},
tsconfigOverride: {
compilerOptions: {
// TS -> esnext, then leave the rest to babel-preset-env
target: 'esnext',
},
},
check: opts.transpileOnly === false,
Expand Down

0 comments on commit 00f80ac

Please sign in to comment.