-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add success/failure hooks to watch #130
Conversation
I agree we should add this. Can you fix the conflicts? |
Let's fix conflicts and merge. This would be super useful for a bunch of stuff. |
i think i have rebased |
lgtm. |
So the I'm not 100% sure why the If that's not correct, this still now makes the |
@jaredpalmer so this got released in 0.12.1 -- could you comment on the above, re: safety/potential breaking-ness of changing the target override? |
- not sure why this change was made in that PR as it was unrelated to the rest, but it broke some things related to Babel usage and maybe other things - e.g. babel macros were not included per jaredpalmer#413 - and it used `tslib` instead of adding babel helper functions - add a comment of why it seems like the target is overriden to esnext - though I am not sure of the original reasoning, as it has existed since very early versions of TSDX, see jaredpalmer#130 comments
- not sure why this change was made in that PR as it was unrelated to the rest, but it broke some things related to Babel usage and maybe other things - e.g. babel macros were not included per #413 - and it used `tslib` instead of adding babel helper functions - add a comment of why it seems like the target is overriden to esnext - though I am not sure of the original reasoning, as it has existed since very early versions of TSDX, see #130 comments
thanks for the great PR! @all-contributors please add @hedgerh for ideas, docs, code, tests |
I've put up a pull request to add @hedgerh! 🎉 |
Argh, found another oversight in this PR while looking at #669. This ended up adding these lines to opts.name = opts.name || appPackageJson.name;
opts.input = await getInputs(opts.entry, appPackageJson.source); Which are redundant with the |
- another thing that was missed in jaredpalmer#130 - these sets are already done in normalizeOpts, no need to redundantly perform them again - fortunately this wasn't inconsistent with normalizeOpts, so no harm done before this got out Co-Authored-By: Kotaro Sugawara <kotarella1110@gmail.com>
- another thing that was missed in #130 - these sets are already done in normalizeOpts, no need to redundantly perform them again - fortunately this wasn't inconsistent with normalizeOpts, so no harm done before this got out Co-Authored-By: Kotaro Sugawara <kotarella1110@gmail.com>
- another thing that was missed in jaredpalmer#130 - these sets are already done in normalizeOpts, no need to redundantly perform them again - fortunately this wasn't inconsistent with normalizeOpts, so no harm done before this got out Co-Authored-By: Kotaro Sugawara <kotarella1110@gmail.com>
Resolves #104
Adds flags to the
tsdx
CLI for running commands on success, first success, and failure of builds when runningwatch
. Usage:Still thinking about how to test these, and maybe even the
watch
command in general.PS. I also added a
start
command in thetsdx
project to run tsc in watch mode to re-bundle on changes.