Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(format): alphabetize package.json deps #398

Merged
merged 1 commit into from
Dec 28, 2019
Merged

(format): alphabetize package.json deps #398

merged 1 commit into from
Dec 28, 2019

Conversation

agilgur5
Copy link
Collaborator

  • this is done automatically when adding a dependency via Yarn / NPM
    • (but not when doing so manually)
    • format as separate commit so it won't need to be repeated or
      randomly introduced in others

@agilgur5
(format): alphabetize package.json deps
7fa1e1c 
- this is done automatically when adding a dependency via Yarn / NPM
  - (but not when doing so manually)
  - format as separate commit so it won't need to be repeated or
    randomly introduced in others
@agilgur5 agilgur5 mentioned this pull request Dec 27, 2019
Merged
@agilgur5
Copy link
Collaborator Author

Seems like this came from #130 . Maybe should run yarn or something on pre-commit to automatically alphabetize as well? That could cause some confusion if deps are updated during pre-commit though...

@swyxio
Copy link
Collaborator

swyxio commented Dec 28, 2019

imo its not a big deal, but thanks for doing it

@swyxio swyxio merged commit 27ba1dd into jaredpalmer:master Dec 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agilgur5 @swyxio