Skip to content

Commit

Permalink
(clean): remove redundant tsconfig strict opts in templates (#673)
Browse files Browse the repository at this point in the history
- noImplicitAny, noImplicitThis, alwaysStrict, strictNullChecks,
  strictFunctionTypes, and strictPropertyInitialization are already
  enabled by strict, no need to configure them twice
  - beginners could also be confused by redundant options (like I was
    at one point)
    - and including them may have also unintentionally encouraged folks
      to turn them off
  • Loading branch information
agilgur5 authored Apr 12, 2020
1 parent 2930943 commit 2dd4396
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 18 deletions.
6 changes: 0 additions & 6 deletions templates/basic/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,6 @@
"sourceMap": true,
"rootDir": "./src",
"strict": true,
"noImplicitAny": true,
"strictNullChecks": true,
"strictFunctionTypes": true,
"strictPropertyInitialization": true,
"noImplicitThis": true,
"alwaysStrict": true,
"noUnusedLocals": true,
"noUnusedParameters": true,
"noImplicitReturns": true,
Expand Down
6 changes: 0 additions & 6 deletions templates/react-with-storybook/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,6 @@
"sourceMap": true,
"rootDir": "./src",
"strict": true,
"noImplicitAny": true,
"strictNullChecks": true,
"strictFunctionTypes": true,
"strictPropertyInitialization": true,
"noImplicitThis": true,
"alwaysStrict": true,
"noUnusedLocals": true,
"noUnusedParameters": true,
"noImplicitReturns": true,
Expand Down
6 changes: 0 additions & 6 deletions templates/react/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,6 @@
"sourceMap": true,
"rootDir": "./src",
"strict": true,
"noImplicitAny": true,
"strictNullChecks": true,
"strictFunctionTypes": true,
"strictPropertyInitialization": true,
"noImplicitThis": true,
"alwaysStrict": true,
"noUnusedLocals": true,
"noUnusedParameters": true,
"noImplicitReturns": true,
Expand Down

0 comments on commit 2dd4396

Please sign in to comment.