Skip to content

Commit

Permalink
(clean): remove all references to --define (#636)
Browse files Browse the repository at this point in the history
- these have been commented out for a long time now
- babel-plugin-transform-replace-expressions also isn't in the
  dependencies either

- they were borrowed from microbundle afaik, but both support babelrc
  nowadays; I think these defines are better configured there than
  with flags anyway
  • Loading branch information
agilgur5 authored Mar 24, 2020
1 parent e84e8d6 commit 6e34b20
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 5 deletions.
4 changes: 0 additions & 4 deletions src/babelPluginTsdx.ts
Original file line number Diff line number Diff line change
Expand Up @@ -73,10 +73,6 @@ export const babelPluginTsdx = babelPlugin.custom(() => ({
name: 'babel-plugin-transform-rename-import',
replacements,
},
isTruthy(customOptions.defines) && {
name: 'babel-plugin-transform-replace-expressions',
replace: customOptions.defines,
},
{
name: 'babel-plugin-transform-async-to-promises',
inlineHelpers: true,
Expand Down
1 change: 0 additions & 1 deletion src/createRollupConfig.ts
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,6 @@ export async function createRollupConfig(
targets: opts.target === 'node' ? { node: '8' } : undefined,
extractErrors: opts.extractErrors,
format: opts.format,
// defines: opts.defines,
},
}),
opts.env !== undefined &&
Expand Down

0 comments on commit 6e34b20

Please sign in to comment.