(clean): remove all references to --define #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- these have been commented out for a long time now - babel-plugin-transform-replace-expressions also isn't in the dependencies either - they were borrowed from microbundle afaik, but both support babelrc nowadays; I think these defines are better configured there than with flags anyway
paul-vd
pushed a commit
to EezyQuote/tsdx
that referenced
this pull request
Dec 1, 2020
- these have been commented out for a long time now - babel-plugin-transform-replace-expressions also isn't in the dependencies either - they were borrowed from microbundle afaik, but both support babelrc nowadays; I think these defines are better configured there than with flags anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these have been commented out for a long time now
babel-plugin-transform-replace-expressions also isn't in the
dependencies either
they were borrowed from microbundle afaik, but both support babelrc
nowadays; I think these defines are better configured there than
with flags anyway