Add support for custom .npmrc #811
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/formium/tsdx/nqe6ek8zr |
agilgur5
added
the
scope: templates
| const args = getInstallArgs(cmd, deps).join(' '); | ||
| await shell.exec(`${cmd} ${args}`, { | ||
| silent: true, | ||
| }); |
There was a problem hiding this comment.
I'm not sure that these are functionally equivalent. execa has an option to use a shell as well
There was a problem hiding this comment.
Yes that's what I thought, but something funky must be going on, if you add an .npmrc to one of the templates pointing to a private npm registry and include a dependency from that private registry, you'll see that execa doesn't work at all
There was a problem hiding this comment.
@agilgur5 await execa(cmd, getInstallArgs(cmd, deps), { shell: true }) does not work
There was a problem hiding this comment.
@agilgur5 Any update? Can this go in or what changes should I make? Would rather not maintain a fork of TSDX
There was a problem hiding this comment.
Please don't expect an immediate response only 24 hours after you took 5 days to respond to a comment... I pay companies for premium support and don't get a response that fast, but you're asking a volunteer to respond faster than that and than you yourself did, for a private registry feature at that.
That's counterproductive and does the opposite of motivating maintainers.
Would rather not maintain a fork of TSDX
It sounds like you already are if you have custom templates??? You said yourself "I was building a modified version of TSDX"...
tsdx create does not create an .npmrc and all deps it installs are public, so there's no need for one, except in a fork
We have also generally recommend patch-package when one needs further customization and this is a good use-case for it
There was a problem hiding this comment.
It sounds like this is an upstream issue in execa and so I think an issue should be filed there. I looked there and there actually is an existing issue on this exact topic: sindresorhus/execa#380
The fix there is to use cwd. If that resolves it, I think it would be a much better option than using shelljs which has various explicit caveats to its usage (several listed in execa's shell option that I linked previously). If it doesn't, I'd suggest filing an issue upstream
agilgur5
added
problem: stale
|
So I was looking at CRA issues/PRs to potentially better understand the case for #502 and I found this issue regarding private registries: facebook/create-react-app#8425 That issue is slightly different in that it's about installing a private template, not just private deps, but it's the same concept. Then when I thought about it, I remembered a template shouldn't include its own |
|
Using tsdx directly and copy pasting templates, instead of maintaining a custom tsdx. |
I was building a modified version of TSDX (custom themes), and one of the issues I faced was that if templates had private packages, even though the template had a correct .npmrc the install step wouldn't pick it up and timeout, the solution was to use shelljs instead.
This would go hand in hand with #502 as well.