Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add patch-package reference to Customization section #855

Merged
merged 1 commit into from
Sep 9, 2020

Conversation

agilgur5
Copy link
Collaborator

@agilgur5 agilgur5 commented Sep 7, 2020

Description

  • for when you need to make some small changes to the internal code and
    forking is a bit too extreme of an option

    • hopefully patch-package means folks get their changes in faster
      without waiting for PRs and means folks don't have to use outdated
      forks etc
  • it was first recommended by Shawn in issues then strongly recommended
    by Jared and I've recommended it a few times too for smaller changes

    • Quoting Jared: "Yes, to documenting patch-package as ultimate
      escape hatch"

Tags

Referenced in:

@agilgur5 agilgur5 added the scope: docs Documentation could be improved. Or changes that only affect docs label Sep 7, 2020
@vercel
Copy link

vercel bot commented Sep 7, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/formium/tsdx/88uj5ofk4
✅ Preview: https://tsdx-git-fork-agilgur5-patch-package-docs.formium.vercel.app

- for when you need to make some small changes to the internal code and
  forking is a bit too extreme of an option
  - hopefully patch-package means folks get their changes in faster
    without waiting for PRs and means folks don't have to use outdated
    forks etc

- it was first recommended by Shawn in issues then strongly recommended
  by Jared and I've recommended it a few times too for smaller changes
  - Quoting Jared: "Yes, to documenting patch-package as ultimate
    escape hatch"
Copy link
Collaborator Author

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@agilgur5 agilgur5 merged commit 08a8ef8 into jaredpalmer:master Sep 9, 2020
paul-vd pushed a commit to EezyQuote/tsdx that referenced this pull request Dec 1, 2020
…lmer#855)

- for when you need to make some small changes to the internal code and
  forking is a bit too extreme of an option
  - hopefully patch-package means folks get their changes in faster
    without waiting for PRs and means folks don't have to use outdated
    forks etc

- it was first recommended by Shawn in issues then strongly recommended
  by Jared and I've recommended it a few times too for smaller changes
  - Quoting Jared: "Yes, to documenting patch-package as ultimate
    escape hatch"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: docs Documentation could be improved. Or changes that only affect docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant