-
Notifications
You must be signed in to change notification settings - Fork 111
Character classes #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Character classes #143
Conversation
Hi @fsdude would you please also resolve the conflicts, or kindly inform if unavailable to? Thank you. |
Hello! Yeah.. lately I've been busy with some work. I don't know if I'll be able to fix this soon, sorry for that |
@fsdude Thank you. |
…de/pt.javascript.info into fsdude-02-regexp-character-classes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kiniggit, @luizclr, @adriavieira314, @Mr-Saxobeat, please since @fsdude might be unavailable I would appreciate if any of you could review this PR #143 , including my revision.
Thank you.
Please make the requested changes. After it, add a comment "/done". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since @fsdude is not available, I applied the changes and will wait for another reviewer.
Closing and re-opening a new one for resolving conflict. |
Specified changes in commits.
Just following english version: https://github.com/javascript-tutorial/en.javascript.info/tree/master/9-regular-expressions/02-regexp-character-classes