This repository has been archived by the owner on Nov 15, 2022. It is now read-only.
Changed use statement for registry #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Marcus, Thanks for the PR. The DoctrineBundle has been moved from Symfony to Doctrine in Symfony 2.1, but it's still present at the current location in 2.0. I think we should have two versions of this multiParamBundle, in order to support both 2.1 and 2.0 versions? |
|
Hi Joshua, I think this would be the best way. Or create a tag (from a version prior to yesterdays composer.json commit) for 2.0 compatibility. |
|
And after some more investigation I guess there are more places that need to be changed. Will update the PR accordingly. |
|
I have opened a new PR for this problems: #5 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The registry had been moved from symfony to doctrine.