Skip to content
This repository has been archived by the owner on Nov 15, 2022. It is now read-only.

[WIP] Compatibility fixes for Symfony 2.1 #5

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[WIP] Compatibility fixes for Symfony 2.1 #5

wants to merge 3 commits into from

Conversation

daFish
Copy link
Contributor

@daFish daFish commented Jul 31, 2012

This is a work in progress PR for compatibility fixes with Symfony 2.1.

@daFish daFish mentioned this pull request Jul 31, 2012
Closed
@basdenooijer basdenooijer mentioned this pull request Aug 1, 2012
Open
@daFish
Copy link
Contributor Author

daFish commented Aug 7, 2012

Could someone please have a look about using the converter with the options syntax? Like @MultiParamConverter("fooid", "AcmeFooBundle:Foo", options={"id" = "fooid"})

@daFish
Copy link
Contributor Author

daFish commented Oct 31, 2012

So, after some more investigation it looks like this bundle isn't needed as I was able to use @ParamConverter more than once. At least for that part the bundle isn't needed. Maybe the other features can be ported to SensioFrameworkExtraBundle?

@jaytaph
Copy link
Owner

jaytaph commented Oct 31, 2012

The paramconverter was changed recently which allows some of the functionality that multiparambundle has. It might be a good idea to check out what is still missing and port it over.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daFish @jaytaph