Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added: Czech translate #885

Merged
merged 2 commits into from
Sep 20, 2021
Merged

Added: Czech translate #885

merged 2 commits into from
Sep 20, 2021

Conversation

rdurica
Copy link
Contributor

@rdurica rdurica commented Sep 18, 2021

Added czech translate

Description

Created translates for czech language

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Screenshot from 2021-09-18 23-06-57

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run the make format command to format my code
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have added my name and/or github handle to AUTHORS.rst
  • I have added my change to CHANGES.rst
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Sep 19, 2021

Codecov Report

Merging #885 (84d17f4) into master (e3065b9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #885   +/-   ##
=======================================
  Coverage   97.69%   97.69%           
=======================================
  Files          19       19           
  Lines         999      999           
  Branches      151      151           
=======================================
  Hits          976      976           
  Misses         10       10           
  Partials       13       13           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3065b9...84d17f4. Read the comment docs.

Copy link
Contributor

@jeking3 jeking3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The translations look good (through google translate).

The only issue I see is the headers in some of the other files look a little different, for example the Last Translator is empty in the other locale files. Check https://github.com/jazzband/django-simple-history/tree/master/simple_history/locale and make sure the headers match up with the other files and I think this will be good to go.

@rdurica
Copy link
Contributor Author

rdurica commented Sep 20, 2021

The translations look good (through google translate).

The only issue I see is the headers in some of the other files look a little different, for example the Last Translator is empty in the other locale files. Check https://github.com/jazzband/django-simple-history/tree/master/simple_history/locale and make sure the headers match up with the other files and I think this will be good to go.

I changed the header so it looks almost identical 84d17f4

Am not sure about this line. It looks like it was generated/updated directly with Poedit. // If you want i can put it there manually.

@rdurica rdurica requested a review from jeking3 September 20, 2021 18:12
Copy link
Contributor

@jeking3 jeking3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for those changes.

@jeking3 jeking3 merged commit 650213f into jazzband:master Sep 20, 2021
jeking3 added a commit to cloudtruth/django-simple-history that referenced this pull request Sep 29, 2021
jeking3 added a commit that referenced this pull request Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants