-
-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pip 20.0.2 does not support relative paths for cache dir #1061
Labels
Comments
Hello @kammala, Thanks for the issue and reproducible steps! You have already researched the bug, so nicely 🙏 |
atugushev
added
the
good first issue
A good item for first time contributors to work on
label
Feb 10, 2020
was playing around and found another way to get into similar trouble using > env PIP_TOOLS_CACHE_DIR='.cache' venv/bin/pip-compile --build-isolation reqs.in --output-file reqs.txt
Traceback (most recent call last):
File "venv/bin/pip-compile", line 11, in <module>
load_entry_point('pip-tools', 'console_scripts', 'pip-compile')()
File "venv/lib/python3.8/site-packages/click/core.py", line 764, in __call__
return self.main(*args, **kwargs)
File "venv/lib/python3.8/site-packages/click/core.py", line 717, in main
rv = self.invoke(ctx)
File "venv/lib/python3.8/site-packages/click/core.py", line 956, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "venv/lib/python3.8/site-packages/click/core.py", line 555, in invoke
return callback(*args, **kwargs)
File "venv/lib/python3.8/site-packages/click/decorators.py", line 17, in new_func
return f(get_current_context(), *args, **kwargs)
File "pip-tools/piptools/scripts/compile.py", line 385, in cli
results = resolver.resolve(max_rounds=max_rounds)
File "pip-tools/piptools/resolver.py", line 165, in resolve
has_changed, best_matches = self._resolve_one_round()
File "pip-tools/piptools/resolver.py", line 260, in _resolve_one_round
their_constraints.extend(self._iter_dependencies(best_match))
File "pip-tools/piptools/resolver.py", line 366, in _iter_dependencies
dependencies = self.repository.get_dependencies(ireq)
File "pip-tools/piptools/repositories/pypi.py", line 287, in get_dependencies
wheel_cache = WheelCache(self._cache_dir, self.options.format_control)
File "pip-tools/venv/lib/python3.8/site-packages/pip/_internal/cache.py", line 287, in __init__
super(WheelCache, self).__init__(
File "pip-tools/venv/lib/python3.8/site-packages/pip/_internal/cache.py", line 53, in __init__
assert not cache_dir or os.path.isabs(cache_dir)
AssertionError |
kammala
added a commit
to kammala/pip-tools
that referenced
this issue
Feb 11, 2020
3 tasks
kammala
added a commit
to kammala/pip-tools
that referenced
this issue
Feb 11, 2020
This was referenced Oct 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
In this PR
pip
starts relying on path normalization outside ofWheelCache
class, while it is still being instantiated manually bypip-tools
without path normalization.Using normalized path should be backward compatible with older versions of pip as well, so it should be safe to do path normalization on
pip-tools
side.Steps to reproduce:
The text was updated successfully, but these errors were encountered: