Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize cache_dir path to be compatible with pip v20 #1062

Merged
merged 1 commit into from
Feb 14, 2020

Conversation

kammala
Copy link
Contributor

@kammala kammala commented Feb 11, 2020

Fixes #1061

Always use normalized path for cache directory as it is required in newer versions of pip

Contributor checklist
  • Provided the tests for the changes.
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@atugushev atugushev changed the title Normalize cache_dir path to be compatible with pip v20. (#1061) Normalize cache_dir path to be compatible with pip v20 Feb 11, 2020
@codecov
Copy link

codecov bot commented Feb 11, 2020

Codecov Report

Merging #1062 into master will decrease coverage by 0.96%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1062      +/-   ##
==========================================
- Coverage   99.26%   98.29%   -0.97%     
==========================================
  Files          34       34              
  Lines        2446     2463      +17     
  Branches      306      307       +1     
==========================================
- Hits         2428     2421       -7     
- Misses         10       30      +20     
- Partials        8       12       +4     
Impacted Files Coverage Δ
tests/test_repository_pypi.py 81.11% <0.00%> (-18.89%) ⬇️
piptools/repositories/pypi.py 90.33% <0.00%> (-2.35%) ⬇️
piptools/utils.py 98.67% <0.00%> (-1.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d405bf9...d61a28e. Read the comment docs.

@pradyunsg
Copy link
Contributor

While I'm here -- heads up that we'd be making changes to pip's resolver interface in the coming release; I suggest you track how master evolves (and provide inputs!) to make sure y'all aren't completely blindsided. :)

@atugushev
Copy link
Member

@pradyunsg thanks for the heads-up! Eagerly waiting for new resolver 😊

Copy link
Member

@atugushev atugushev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@atugushev atugushev added this to the 4.4.2 milestone Feb 14, 2020
@atugushev atugushev merged commit 3180fad into jazzband:master Feb 14, 2020
@atugushev
Copy link
Member

@kammala thanks for your first contribution! 👍 👏

@atugushev atugushev modified the milestones: 4.4.2, 4.5.0 Feb 20, 2020
@atugushev
Copy link
Member

pip-tools v4.5.0 is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pip 20.0.2 does not support relative paths for cache dir
3 participants