-
-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalize cache_dir path to be compatible with pip v20 #1062
Normalize cache_dir path to be compatible with pip v20 #1062
Conversation
ae32aa5
to
92b11e0
Compare
Codecov Report
@@ Coverage Diff @@
## master #1062 +/- ##
==========================================
- Coverage 99.26% 98.29% -0.97%
==========================================
Files 34 34
Lines 2446 2463 +17
Branches 306 307 +1
==========================================
- Hits 2428 2421 -7
- Misses 10 30 +20
- Partials 8 12 +4
Continue to review full report at Codecov.
|
3b55d78
to
d61a28e
Compare
While I'm here -- heads up that we'd be making changes to pip's resolver interface in the coming release; I suggest you track how master evolves (and provide inputs!) to make sure y'all aren't completely blindsided. :) |
@pradyunsg thanks for the heads-up! Eagerly waiting for new resolver 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@kammala thanks for your first contribution! 👍 👏 |
|
Fixes #1061
Always use normalized path for cache directory as it is required in newer versions of pip
Contributor checklist