Fix compatibility with pip master (pip>=20.0) #953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PackageFinder moved to pip._internal.index.package_finder FormatControl moved to pip._internal.models.format_control See: pypa/pip#7144
Codecov Report
@@ Coverage Diff @@
## master #953 +/- ##
=========================================
+ Coverage 99.1% 99.1% +<.01%
=========================================
Files 35 35
Lines 2336 2338 +2
Branches 301 301
=========================================
+ Hits 2315 2317 +2
Misses 13 13
Partials 8 8
Continue to review full report at Codecov.
|
atugushev
changed the title
|
Thanks for reviewing this, @codingjoe! 🎉 |
blueyed
reviewed
Oct 25, 2019
atugushev
added a commit
to atugushev/pip-tools
that referenced
this pull request
Nov 4, 2019
See details in jazzband#953 (comment)
2 tasks
atugushev
changed the title
JiachenSmith
pushed a commit
to JiachenSmith/pip-tools
that referenced
this pull request
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Cron job is failing, see: https://github.com/jazzband/pip-tools/commit/023d7cabe36277bf9e5a5f37ebca299d87f4e36d/checks
What's fixed
indexsub-package pypa/pip#7144PackageFindermoved topip._internal.index.package_finderFormatControlmoved topip._internal.models.format_controlPass require_hashes directly to Resolver
Additional notes
pragma: no coverprevents suddenly decreasing coverage if pip master fails again. Any other suggestions on how to achieve this?Changelog-friendly one-liner: Add compatibility with
pip>=20.0Contributor checklist
Provided the tests for the changes.