Remove RequirementSet.require_hashes #7068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrahunt
added
type: refactor
cjerdonek
reviewed
Sep 24, 2019
Right now, yes. I think it's reasonable to expect that to stay true going forward but I do prefer if we defer making that choice until we see that as being something that causes functional issues. |
|
Hello! I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the |
Removes the only dynamic state from Resolver, at the cost of passing an extra variable to 2 methods.
This removes some of the dependence of the Resolver on our specific RequirementSet implementation.
chrahunt
force-pushed
the
refactor/decouple-req-set-resolver
branch
from
a47803f
to
b8fb97a
Compare
|
Updated and ready for review. Since there is now no state being changed within |
pradyunsg
approved these changes
Oct 20, 2019
atugushev
added a commit
to atugushev/pip-tools
that referenced
this pull request
Oct 20, 2019
2 tasks
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this change is two-fold:
ResolverandRequirementSet, towards the goal of havingResolver.resolve()accept a plainIterable[InstallRequirement]RequirementSetitself, since after build refactoring it should not need to existThis does add one parameter to
Resolver, however in later refactoring we should be able to encapsulate all of the hash-related logic in an object thatResolverwould use to query for and prepare requirements.