Upgrade to Python 3.7+ syntax #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #234 +/- ##
=======================================
Coverage 99.07% 99.07%
=======================================
Files 24 24
Lines 5085 5088 +3
=======================================
+ Hits 5038 5041 +3
Misses 47 47
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jborean93
reviewed
Aug 19, 2023
There was a problem hiding this comment.
Thanks for working on this. While I believe the type annotations might be fine if the future annotations are used I would prefer to ensure the mypy checks for each supported Python version still work so we might have to still use some of the older typing constructs.
dolfinus
force-pushed
the
pyupgrade
branch
2 times, most recently
from
ea1f79e to
cc0f3ee
Compare
jborean93
reviewed
Aug 19, 2023
jborean93
approved these changes
Aug 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyupgrade --py37-plus ./**/*.pyto upgrade Python 2.7 syntax to 3.7+%sand.format()syntax with f-strings%sstring syntax, but without explicit"msg" % (variables,)- letloggingdo this if logging is enabled for a specific level# typecomments to type hints, replaceList[type],Optional[type]andUnion[type1, type2]withlist[type],type | Noneandtype1 | type2(usingfrom __future__ import annotations).os.fspathinstead ofstrto convert Path-like objects to string path representationprint