Skip to content

Commit

Permalink
fix invalid log (kubernetes-retired#2429)
Browse files Browse the repository at this point in the history
* fix invalid log

* use `%q`
  • Loading branch information
carlory authored and Jay Boyd committed Oct 31, 2018
1 parent 22b191e commit f3f2dde
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions pkg/controller/broker_client_manager.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,11 @@ package controller

import (
"fmt"
"github.com/golang/glog"
osb "github.com/pmorie/go-open-service-broker-client/v2"
"reflect"
"sync"

"github.com/golang/glog"
osb "github.com/pmorie/go-open-service-broker-client/v2"
)

// BrokerKey defines a key which points to a broker (cluster wide or namespaced)
Expand Down Expand Up @@ -84,7 +85,7 @@ func (m *BrokerClientManager) UpdateBrokerClient(brokerKey BrokerKey, clientConf
existing, found := m.clients[brokerKey]

if !found || configHasChanged(existing.clientConfig, clientConfig) {
glog.V(4).Infof("Updating OSB client for broker %s, URL: %s", brokerKey.String(), clientConfig.URL)
glog.V(4).Infof("Updating OSB client for broker %q, URL: %s", brokerKey.String(), clientConfig.URL)
return m.createClient(brokerKey, clientConfig)
}

Expand All @@ -96,7 +97,7 @@ func (m *BrokerClientManager) RemoveBrokerClient(brokerKey BrokerKey) {
m.mu.Lock()
defer m.mu.Unlock()

glog.V(4).Info("Removing OSB client for broker %s", brokerKey.String())
glog.V(4).Infof("Removing OSB client for broker %q", brokerKey.String())
delete(m.clients, brokerKey)
}

Expand Down

0 comments on commit f3f2dde

Please sign in to comment.