This repository has been archived by the owner on May 6, 2022. It is now read-only.
fix invalid log #2429
Merged
fix invalid log #2429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
size/XS
MHBauer
approved these changes
Oct 21, 2018
| @@ -96,7 +97,7 @@ func (m *BrokerClientManager) RemoveBrokerClient(brokerKey BrokerKey) { | |||
| m.mu.Lock() | |||
| defer m.mu.Unlock() | |||
|
|
|||
| glog.V(4).Info("Removing OSB client for broker %s", brokerKey.String()) | |||
| glog.V(4).Infof("Removing OSB client for broker %s", brokerKey.String()) | |||
k8s-ci-robot
added
the
do-not-merge/hold
1 similar comment
|
/hold cancel |
|
/ok-to-test |
|
Yes please use a %q
… On Oct 22, 2018, at 2:21 AM, 帝俊 ***@***.***> wrote:
@carlory commented on this pull request.
In pkg/controller/broker_client_manager.go <#2429 (comment)>:
> @@ -96,7 +97,7 @@ func (m *BrokerClientManager) RemoveBrokerClient(brokerKey BrokerKey) {
m.mu.Lock()
defer m.mu.Unlock()
- glog.V(4).Info("Removing OSB client for broker %s", brokerKey.String())
+ glog.V(4).Infof("Removing OSB client for broker %s", brokerKey.String())
Thanks for your review. I also think %q is better than %s. If @duglin <https://github.com/duglin> want a %q, I will change them in the go file.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#2429 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AB2sX2AHyC3Q8s6BMY-5hfO2VeJOFK4Aks5unR2ugaJpZM4XylIx>.
|
k8s-ci-robot
added
lgtm
|
/test pull-service-catalog-xbuild |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jboyd01 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
jboyd01
pushed a commit
to jboyd01/service-catalog
that referenced
this pull request
Oct 31, 2018
* fix invalid log * use `%q`
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.