Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] update pull request template to absolute links #717

Merged
merged 1 commit into from
Mar 23, 2022
Merged

[chore] update pull request template to absolute links #717

merged 1 commit into from
Mar 23, 2022

Conversation

benschac
Copy link
Contributor

@benschac benschac commented Mar 22, 2022

What does this PR do and why?

Did a quick google search and it looks like relative paths are broken in GitHub Pull Request templates: github/markup#576. This PR updates relative paths to absolute paths in the pull request template for the project.

After this PR is merged, contributors will be able to click the Acceptance checklist links and be taken to the docs and not a 404 page.

Screenshots or screen recordings

If applicable, provide screenshots or screen recordings to demonstrate the
changes.

Acceptance checklist

@benschac benschac reopened this Mar 22, 2022
@benschac benschac requested a review from aeolianeth March 22, 2022 11:37
@benschac benschac changed the title update-pull-request-template [chore] update-pull-request-template Mar 22, 2022
@benschac benschac changed the title [chore] update-pull-request-template [chore] update pull request template to absolute links Mar 22, 2022
Copy link
Contributor

@aeolianeth aeolianeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @benschac , good to know about that bug.

@aeolianeth aeolianeth merged commit e0bcbd3 into jbx-protocol:main Mar 23, 2022
@benschac
Copy link
Contributor Author

Super weird my editor didn't pick up the formatting issue. Going to look into it on my end. Sorry about that.

tomquirk pushed a commit that referenced this pull request Feb 11, 2023
tomquirk pushed a commit that referenced this pull request Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants