Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative Links in Pull Requests #576

Closed
muescha opened this issue Dec 7, 2015 · 7 comments
Closed

Relative Links in Pull Requests #576

muescha opened this issue Dec 7, 2015 · 7 comments

Comments

@muescha
Copy link

muescha commented Dec 7, 2015

it should use relative links in pullrequests and comments in pull requests

Example:

where

i write something in a comment of a pull request

what

i would like to write [options](website/documentation/options.md#default-ui-options)

current

it matches to:

https://github.com/dimsemenov/PhotoSwipe/pull/905/website/documentation/options.md#default-ui-options

expected

it should be matched to this:

https://github.com/dimsemenov/PhotoSwipe/blob/master/website/documentation/options.md#default-ui-options

@muescha
Copy link
Author

muescha commented Dec 7, 2015

its different from #285 (relative links in issues)

@kivikakk
Copy link
Contributor

👋 Hey, thanks for the report! As this isn't an issue with the markup gem itself, would you be able to reach out to our support team with this feature request? Thank you very much!

@OmgImAlexis
Copy link

@kivikakk shouldn't this stay open like other feature requests here?

For example #913

@kivikakk
Copy link
Contributor

@OmgImAlexis This isn't a repository for general GitHub feature requests, it's for things specifically to do with the github-markup gem. We're just now working through the backlog of issues and closing out those that aren't relevant and directing them to the support team, so we can actually keep work on Markup itself focused, and get the feature requests to the proper channels! 😃

@muescha
Copy link
Author

muescha commented Mar 23, 2017

@kivikakk thx for pointing out the right channel for this request "issue"

🚀

@pnlph
Copy link

pnlph commented Jan 29, 2020

@kivikakk From what i read, I understand that you have a proper channel to handle feature requests that seems to be the Github Feedback Form

But somehow the information should be posted back here, don't you think? I just sent a feature request about #576 that could have been avoided if i could find the current state here.

@kivikakk
Copy link
Contributor

@pnlph it depends on the team that handled the feature. this is not a repository for feature requests so in general they won’t make it here unless someone goes to special effort.

i’m no longer a github employee so i can’t help any further with making that kind of thing happen. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants