Add rewired to project #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
This was referenced Apr 26, 2022
Merged
benschac
changed the title
benschac
force-pushed
the
04-25-add_rewire_to_project
branch
from
31f59b8
to
fa4b4fe
Compare
benschac
force-pushed
the
04-25-yarn_add_react_scripts_5
branch
from
e0bd5eb
to
ed903f3
Compare
benschac
force-pushed
the
04-25-add_rewire_to_project
branch
from
fa4b4fe
to
01e99d4
Compare
benschac
commented
Apr 30, 2022
| "start": "yarn compile-styles && ESLINT_NO_DEV_ERRORS=true react-scripts start", | ||
| "build": "react-scripts build", | ||
| "start": "yarn compile-styles && ESLINT_NO_DEV_ERRORS=true react-app-rewired start", | ||
| "build": "react-app-rewired build", |
There was a problem hiding this comment.
updated the command per the documentation: https://github.com/timarney/react-app-rewired#3-flip-the-existing-calls-to-react-scripts-in-npm-scripts-for-start-build-and-test
|
Specifically adding @peripheralist to this to address their concerns here: #712 (comment) |
benschac
force-pushed
the
04-25-yarn_add_react_scripts_5
branch
from
1fde032
to
a9eae13
Compare
benschac
force-pushed
the
04-25-add_rewire_to_project
branch
from
01e99d4
to
3f6acd7
Compare
benschac
force-pushed
the
04-25-yarn_add_react_scripts_5
branch
from
a9eae13
to
929b169
Compare
benschac
force-pushed
the
04-25-add_rewire_to_project
branch
from
3f6acd7
to
52d1c48
Compare
* add missing polyfills and modules * remove unused code * update uniswap v3 sdk (#870) * update uniswap v3 sdk * update json imports in app (#871) * update json imports in app * update eslint configuration (#876) * update eslint configuration * remove eslint, set react version * remove issuetickets component * fix-small-eslint-issues (#963) * fix-small-eslint-issues * set config overrides file as node / common js for eslint
benschac
added a commit
that referenced
this pull request
May 12, 2022
* add rewire to project * add rewire commands * add missing polyfills and modules (#869) * add missing polyfills and modules * remove unused code * update uniswap v3 sdk (#870) * update uniswap v3 sdk * update json imports in app (#871) * update json imports in app * update eslint configuration (#876) * update eslint configuration * remove eslint, set react version * remove issuetickets component * fix-small-eslint-issues (#963) * fix-small-eslint-issues * set config overrides file as node / common js for eslint
benschac
added a commit
that referenced
this pull request
May 15, 2022
* add rewire to project * add rewire commands * add missing polyfills and modules (#869) * add missing polyfills and modules * remove unused code * update uniswap v3 sdk (#870) * update uniswap v3 sdk * update json imports in app (#871) * update json imports in app * update eslint configuration (#876) * update eslint configuration * remove eslint, set react version * remove issuetickets component * fix-small-eslint-issues (#963) * fix-small-eslint-issues * set config overrides file as node / common js for eslint
benschac
added a commit
that referenced
this pull request
May 21, 2022
Add rewired to project (#868) * add rewire to project * add rewire commands * add missing polyfills and modules (#869) * add missing polyfills and modules * remove unused code * update uniswap v3 sdk (#870) * update uniswap v3 sdk * update json imports in app (#871) * update json imports in app * update eslint configuration (#876) * update eslint configuration * remove eslint, set react version * remove issuetickets component * fix-small-eslint-issues (#963) * fix-small-eslint-issues * set config overrides file as node / common js for eslint fix linting issues from main bump eslint dep fix up remaining tyscript issues fix CI build bump jest, configure jest, configure eslint fix package lock
aeolianeth
pushed a commit
that referenced
this pull request
Jun 2, 2022
Add rewired to project (#868) * add rewire to project * add rewire commands * add missing polyfills and modules (#869) * add missing polyfills and modules * remove unused code * update uniswap v3 sdk (#870) * update uniswap v3 sdk * update json imports in app (#871) * update json imports in app * update eslint configuration (#876) * update eslint configuration * remove eslint, set react version * remove issuetickets component * fix-small-eslint-issues (#963) * fix-small-eslint-issues * set config overrides file as node / common js for eslint fix linting issues from main bump eslint dep fix up remaining tyscript issues fix CI build bump jest, configure jest, configure eslint fix package lock
aeolianeth
pushed a commit
that referenced
this pull request
Jun 2, 2022
Add rewired to project (#868) * add rewire to project * add rewire commands * add missing polyfills and modules (#869) * add missing polyfills and modules * remove unused code * update uniswap v3 sdk (#870) * update uniswap v3 sdk * update json imports in app (#871) * update json imports in app * update eslint configuration (#876) * update eslint configuration * remove eslint, set react version * remove issuetickets component * fix-small-eslint-issues (#963) * fix-small-eslint-issues * set config overrides file as node / common js for eslint fix linting issues from main bump eslint dep fix up remaining tyscript issues fix CI build bump jest, configure jest, configure eslint fix package lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do and why?
fixes: #712
What
Why:
react-scriptsdoesn't include node polyfills that the project's dependencies depend on. tl;dr - webpack@5 removed polyfills it included by default, CRA added webpack@5 and now a lot of projects don't work with react-scripts 5. (https://webpack.js.org/blog/2020-10-10-webpack-5-release/#automatic-nodejs-polyfills-removed)How
web3.jshas a documented upgrade path here that I followed: https://github.com/ChainSafe/web3.js#web3-and-create-react-appMoving Forward
More context here:
Screenshots or screen recordings
N/A
Acceptance checklist