fix-small-eslint-issues #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
benschac
force-pushed
the
05-07-fix-small-eslint-issues
branch
from
c5b269e
to
7f08567
Compare
benschac
commented
May 9, 2022
| @@ -82,8 +82,7 @@ export default function ManageTokensModal({ | |||
| plural: true, | |||
| }) | |||
|
|
|||
| // eslint-disable-next-line no-extra-boolean-cast | |||
| const redeemDisabled = !Boolean(hasOverflow) | |||
| const redeemDisabled = !hasOverflow | |||
There was a problem hiding this comment.
wasn't 100% about going around and renaming these.
benschac
commented
May 9, 2022
| @@ -94,11 +92,10 @@ export default function ProjectReserved({ | |||
| label={ | |||
| hideLabel ? undefined : ( | |||
| <> | |||
| {shouldRenderToggle ? ( | |||
| {onToggled ? ( | |||
There was a problem hiding this comment.
but, I renamed this one since it was just one variable.
benschac
commented
May 9, 2022
| @@ -53,7 +53,7 @@ export default function ImageUploader({ | |||
| borderRadius: theme.radii.md, | |||
| }} | |||
| src={url} | |||
| alt="Uploaded image" | |||
| alt="Uploaded user content" | |||
There was a problem hiding this comment.
This wasn't in the initial warning, but it was showing up. It might have just been a stale yarn cache that didn't catch this rule the first time because my bundle/lint changed so dramatically between branches.
There was a problem hiding this comment.
hah, nice. I like this rule :D
benschac
commented
May 9, 2022
| @@ -59,7 +59,7 @@ export default function IssueTokenModal({ | |||
| transactionPending={transactionPending} | |||
| > | |||
| <p> | |||
| {!Boolean(isNewDeploy) ? ( | |||
| {!isNewDeploy ? ( | |||
There was a problem hiding this comment.
This wasn't in the initial warning, but it was showing up. It might have just been a stale yarn cache that didn't catch this rule the first time because my bundle/lint changed so dramatically between branches.
Same here.
benschac
commented
May 9, 2022
| {/* Added a hidden input here because Form.Item needs | ||
| a child Input to work. Need the parent Form.Item to | ||
| {/* Added a hidden input here because Form.Item needs | ||
| a child Input to work. Need the parent Form.Item to |
There was a problem hiding this comment.
Was prettier. Honestly curious how this happened.
aeolianeth
approved these changes
May 11, 2022
benschac
added a commit
that referenced
this pull request
May 11, 2022
* update eslint configuration * remove eslint, set react version * remove issuetickets component * fix-small-eslint-issues (#963) * fix-small-eslint-issues * set config overrides file as node / common js for eslint
benschac
added a commit
that referenced
this pull request
May 11, 2022
* update uniswap v3 sdk * update json imports in app (#871) * update json imports in app * update eslint configuration (#876) * update eslint configuration * remove eslint, set react version * remove issuetickets component * fix-small-eslint-issues (#963) * fix-small-eslint-issues * set config overrides file as node / common js for eslint
benschac
added a commit
that referenced
this pull request
May 11, 2022
* add missing polyfills and modules * remove unused code * update uniswap v3 sdk (#870) * update uniswap v3 sdk * update json imports in app (#871) * update json imports in app * update eslint configuration (#876) * update eslint configuration * remove eslint, set react version * remove issuetickets component * fix-small-eslint-issues (#963) * fix-small-eslint-issues * set config overrides file as node / common js for eslint
benschac
added a commit
that referenced
this pull request
May 11, 2022
* add rewire to project * add rewire commands * add missing polyfills and modules (#869) * add missing polyfills and modules * remove unused code * update uniswap v3 sdk (#870) * update uniswap v3 sdk * update json imports in app (#871) * update json imports in app * update eslint configuration (#876) * update eslint configuration * remove eslint, set react version * remove issuetickets component * fix-small-eslint-issues (#963) * fix-small-eslint-issues * set config overrides file as node / common js for eslint
benschac
added a commit
that referenced
this pull request
May 12, 2022
* add rewire to project * add rewire commands * add missing polyfills and modules (#869) * add missing polyfills and modules * remove unused code * update uniswap v3 sdk (#870) * update uniswap v3 sdk * update json imports in app (#871) * update json imports in app * update eslint configuration (#876) * update eslint configuration * remove eslint, set react version * remove issuetickets component * fix-small-eslint-issues (#963) * fix-small-eslint-issues * set config overrides file as node / common js for eslint
benschac
added a commit
that referenced
this pull request
May 15, 2022
* add rewire to project * add rewire commands * add missing polyfills and modules (#869) * add missing polyfills and modules * remove unused code * update uniswap v3 sdk (#870) * update uniswap v3 sdk * update json imports in app (#871) * update json imports in app * update eslint configuration (#876) * update eslint configuration * remove eslint, set react version * remove issuetickets component * fix-small-eslint-issues (#963) * fix-small-eslint-issues * set config overrides file as node / common js for eslint
benschac
added a commit
that referenced
this pull request
May 21, 2022
Add rewired to project (#868) * add rewire to project * add rewire commands * add missing polyfills and modules (#869) * add missing polyfills and modules * remove unused code * update uniswap v3 sdk (#870) * update uniswap v3 sdk * update json imports in app (#871) * update json imports in app * update eslint configuration (#876) * update eslint configuration * remove eslint, set react version * remove issuetickets component * fix-small-eslint-issues (#963) * fix-small-eslint-issues * set config overrides file as node / common js for eslint fix linting issues from main bump eslint dep fix up remaining tyscript issues fix CI build bump jest, configure jest, configure eslint fix package lock
aeolianeth
pushed a commit
that referenced
this pull request
Jun 2, 2022
Add rewired to project (#868) * add rewire to project * add rewire commands * add missing polyfills and modules (#869) * add missing polyfills and modules * remove unused code * update uniswap v3 sdk (#870) * update uniswap v3 sdk * update json imports in app (#871) * update json imports in app * update eslint configuration (#876) * update eslint configuration * remove eslint, set react version * remove issuetickets component * fix-small-eslint-issues (#963) * fix-small-eslint-issues * set config overrides file as node / common js for eslint fix linting issues from main bump eslint dep fix up remaining tyscript issues fix CI build bump jest, configure jest, configure eslint fix package lock
aeolianeth
pushed a commit
that referenced
this pull request
Jun 2, 2022
Add rewired to project (#868) * add rewire to project * add rewire commands * add missing polyfills and modules (#869) * add missing polyfills and modules * remove unused code * update uniswap v3 sdk (#870) * update uniswap v3 sdk * update json imports in app (#871) * update json imports in app * update eslint configuration (#876) * update eslint configuration * remove eslint, set react version * remove issuetickets component * fix-small-eslint-issues (#963) * fix-small-eslint-issues * set config overrides file as node / common js for eslint fix linting issues from main bump eslint dep fix up remaining tyscript issues fix CI build bump jest, configure jest, configure eslint fix package lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do and why?
Follow up on ESLint changes from here: #876 (comment)
Screenshots or screen recordings
Acceptance checklist