Merge homeassistant fork into origin repo #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added query to get current running roku app
Updated to return the application object
Updated the application object to use the get method so it will default without error
* Remove extra params from Launch * Update core.py
Updated _call to accept response of 204 or 200. Roku will return a 204 if being requested to launch an app that is already running.
This is the first step in adding search for roku from HA, and ultimately haaska for connecting with the new alexa video skill api.
* Add search functionality for roku. (See Search in the roku ECP) This is the first step in adding search for roku from HA, and ultimately haaska for connecting with the new alexa video skill api. * Added support for additional search parameters
jcarbaugh has added a few new commands to his list, and it would be great to have them available! https://github.com/jcarbaugh/python-roku/blob/5b12c15777baf77424b525bdd469509906c13ee7/roku/core.py
jcarbaugh
approved these changes
Sep 16, 2018
This was referenced Jul 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have finally gotten around to fixing merge conflicts on this so it can be merged into the original repo and my fork deleted.