Use codeclimate-action to improve edge-case handling #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Climate does not have an official GitHub action, but there are a few tricky cases that need worked around making it undesirable to use the shell scripts directly. What has caused the most headaches is the absence of required ENV variables for branch and SHA that need conditional handling depending on where the commit came from (commit, pull request, fork, etc). By using a community plugin, the hope is to simplify action config for this project and avoid these gotchas. This also pins the version of SimpleCov to 0.17.x to fix an issue where Code Climate's reporter does not current support versions >= 0.18 (paambaati/codeclimate-action#102 (comment)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code Climate does not have an official GitHub action, but there are a
few tricky cases that need worked around making it undesirable to use
the shell scripts directly. What has caused the most headaches is the
absence of required ENV variables for branch and SHA that need
conditional handling depending on where the commit came from (commit,
pull request, fork, etc). By using a community plugin, the hope is to
simplify action config for this project and avoid these gotchas.
This also pins the version of SimpleCov to 0.17.x to fix an issue where
Code Climate's reporter does not current support versions >= 0.18
(paambaati/codeclimate-action#102 (comment)).