Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

after-build issue with latest simplecov #102

Closed
Yanchek99 opened this issue Feb 14, 2020 · 2 comments
Closed

after-build issue with latest simplecov #102

Yanchek99 opened this issue Feb 14, 2020 · 2 comments
Labels
external Depends on an external resource/project

Comments

@Yanchek99
Copy link

Odd behaviors happening with latest simplecov, seems like an issue getting the committed at timestamp which seems unrelated to the simplecov update but wanted to mention just incase.

SimpleCov version 0.18.2

CI Code

- name: Test & publish code coverage
        uses: paambaati/codeclimate-action@v2.4.0
        env:
          CC_TEST_REPORTER_ID:  foobar
        with:
          coverageCommand: bundle exec rails test
          debug: true

Error

./cc-reporter after-build --exit-code 0 --debug
time="2020-02-14T19:14:44Z" level=debug msg="about to run format-coverage" 
time="2020-02-14T19:14:44Z" level=debug msg="searching for a formatter to use" 
time="2020-02-14T19:14:44Z" level=debug msg="checking coverage.py formatter" 
time="2020-02-14T19:14:44Z" level=debug msg="checking search path coverage.xml for coverage.py formatter" 
time="2020-02-14T19:14:44Z" level=debug msg="checking lcov formatter" 
time="2020-02-14T19:14:44Z" level=debug msg="checking search path coverage/lcov.info for lcov formatter" 
time="2020-02-14T19:14:44Z" level=debug msg="checking simplecov formatter" 
time="2020-02-14T19:14:44Z" level=debug msg="checking search path coverage/.resultset.json for simplecov formatter" 
time="2020-02-14T19:14:44Z" level=debug msg="found file coverage/.resultset.json for simplecov formatter" 
time="2020-02-14T19:14:44Z" level=debug msg="couldn't load committed at from ENV, trying git..." 
Error: json: cannot unmarshal object into Go struct field input.coverage of type []formatters.NullInt
@davehenton
Copy link

Hi @Yanchek99 ,

Dave here with Code Climate. Unfortunately, Code Climate's test reporter isn't compatible with the latest version of SimpleCov. We're actively in touch with the maintainers, and we hope to resolve this in the near future. You can keep track of our progress here: codeclimate/test-reporter#413

For now, the simplest solution is for you to revert back to your previous version of SimpleCov.

@Yanchek99
Copy link
Author

Hey @davehenton, Thanks for quickly commenting on this. I can rollback SimpleCov for now not a problem. I will close this in favor of the other issue.

Thanks again.

@Maarten-vd-Sande Maarten-vd-Sande mentioned this issue Feb 26, 2020
Closed
@paambaati paambaati added the external Depends on an external resource/project label Mar 4, 2020
jcypret added a commit to jcypret/hashid-rails that referenced this issue Aug 9, 2020
@jcypret
Use codeclimate-action to improve edge-case handling
d4e780b 
Code Climate does not have an official GitHub action, but there are a
few tricky cases that need worked around making it undesirable to use
the shell scripts directly. What has caused the most headaches is the
absence of required ENV variables for branch and SHA that need
conditional handling depending on where the commit came from (commit,
pull request, fork, etc). By using a community plugin, the hope is to
simplify action config for this project and avoid these gotchas.

This also pins the version of SimpleCov to 0.17.x to fix an issue where
Code Climate's reporter does not current support versions >= 0.18
(paambaati/codeclimate-action#102 (comment)).
@jcypret jcypret mentioned this issue Aug 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
external Depends on an external resource/project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Yanchek99 @paambaati @davehenton