Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix display name #13

Open
wants to merge 1 commit into
base: accounts
Choose a base branch
from
Open

Fix display name #13

wants to merge 1 commit into from

Conversation

nworr
Copy link
Contributor

@nworr nworr commented Aug 22, 2024

Account::getDisplayName() method can return a simple space string if last name and first name are empty

see

return $this->data['firstname'].' '.$this->data['lastname'];

use trim to check if the displayName value is relevant

@nworr nworr changed the base branch from master to accounts August 22, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant