Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dependency injection for ItemLauncher, KeyProcessor and ReportingHelper #3572

Merged
merged 5 commits into from
May 14, 2024

Remove unused methods from StreamHelper

92cc0de
Select commit
Loading
Failed to load commit list.
Merged

Use dependency injection for ItemLauncher, KeyProcessor and ReportingHelper #3572

Remove unused methods from StreamHelper
92cc0de
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / Android Lint succeeded May 14, 2024 in 9s

18 new alerts

New alerts in code changed by this pull request

  • 2 warnings
  • 16 notes

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 84 in app/src/main/java/org/jellyfin/androidtv/ui/ProgramGridCell.java

See this annotation in the file changed.

Code scanning / Android Lint

Using private resources Warning

The resource @color/lb_default_brand_color is marked as private in androidx.leanback:leanback-preference:1.1.0-rc01

Check warning on line 117 in app/src/main/java/org/jellyfin/androidtv/ui/ProgramGridCell.java

See this annotation in the file changed.

Code scanning / Android Lint

TextView Internationalization Warning

Do not concatenate text displayed with setText. Use resource string with placeholders.

Check notice on line 52 in app/src/main/java/org/jellyfin/androidtv/ui/itemhandling/ItemLauncher.java

See this annotation in the file changed.

Code scanning / Android Lint

Unknown nullness Note

Unknown nullability; explicitly declare as @Nullable or @NonNull to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations

Check notice on line 71 in app/src/main/java/org/jellyfin/androidtv/ui/itemhandling/ItemLauncher.java

See this annotation in the file changed.

Code scanning / Android Lint

Unknown nullness Note

Unknown nullability; explicitly declare as @Nullable or @NonNull to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations

Check notice on line 71 in app/src/main/java/org/jellyfin/androidtv/ui/itemhandling/ItemLauncher.java

See this annotation in the file changed.

Code scanning / Android Lint

Unknown nullness Note

Unknown nullability; explicitly declare as @Nullable or @NonNull to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations

Check notice on line 71 in app/src/main/java/org/jellyfin/androidtv/ui/itemhandling/ItemLauncher.java

See this annotation in the file changed.

Code scanning / Android Lint

Unknown nullness Note

Unknown nullability; explicitly declare as @Nullable or @NonNull to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations

Check notice on line 66 in app/src/main/java/org/jellyfin/androidtv/util/KeyProcessor.java

See this annotation in the file changed.

Code scanning / Android Lint

Unknown nullness Note

Unknown nullability; explicitly declare as @Nullable or @NonNull to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations

Check notice on line 66 in app/src/main/java/org/jellyfin/androidtv/util/KeyProcessor.java

See this annotation in the file changed.

Code scanning / Android Lint

Unknown nullness Note

Unknown nullability; explicitly declare as @Nullable or @NonNull to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations

Check notice on line 186 in app/src/main/java/org/jellyfin/androidtv/util/KeyProcessor.java

See this annotation in the file changed.

Code scanning / Android Lint

Unknown nullness Note

Unknown nullability; explicitly declare as @Nullable or @NonNull to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations

Check notice on line 186 in app/src/main/java/org/jellyfin/androidtv/util/KeyProcessor.java

See this annotation in the file changed.

Code scanning / Android Lint

Unknown nullness Note

Unknown nullability; explicitly declare as @Nullable or @NonNull to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations

Check notice on line 186 in app/src/main/java/org/jellyfin/androidtv/util/KeyProcessor.java

See this annotation in the file changed.

Code scanning / Android Lint

Unknown nullness Note

Unknown nullability; explicitly declare as @Nullable or @NonNull to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations

Check notice on line 186 in app/src/main/java/org/jellyfin/androidtv/util/KeyProcessor.java

See this annotation in the file changed.

Code scanning / Android Lint

Unknown nullness Note

Unknown nullability; explicitly declare as @Nullable or @NonNull to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations

Check notice on line 27 in app/src/main/java/org/jellyfin/androidtv/util/apiclient/ReportingHelper.java

See this annotation in the file changed.

Code scanning / Android Lint

Unknown nullness Note

Unknown nullability; explicitly declare as @Nullable or @NonNull to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations

Check notice on line 27 in app/src/main/java/org/jellyfin/androidtv/util/apiclient/ReportingHelper.java

See this annotation in the file changed.

Code scanning / Android Lint

Unknown nullness Note

Unknown nullability; explicitly declare as @Nullable or @NonNull to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations

Check notice on line 47 in app/src/main/java/org/jellyfin/androidtv/util/apiclient/ReportingHelper.java

See this annotation in the file changed.

Code scanning / Android Lint

Unknown nullness Note

Unknown nullability; explicitly declare as @Nullable or @NonNull to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations

Check notice on line 55 in app/src/main/java/org/jellyfin/androidtv/util/apiclient/ReportingHelper.java

See this annotation in the file changed.

Code scanning / Android Lint

Unknown nullness Note

Unknown nullability; explicitly declare as @Nullable or @NonNull to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations

Check notice on line 55 in app/src/main/java/org/jellyfin/androidtv/util/apiclient/ReportingHelper.java

See this annotation in the file changed.

Code scanning / Android Lint

Unknown nullness Note

Unknown nullability; explicitly declare as @Nullable or @NonNull to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations

Check notice on line 55 in app/src/main/java/org/jellyfin/androidtv/util/apiclient/ReportingHelper.java

See this annotation in the file changed.

Code scanning / Android Lint

Unknown nullness Note

Unknown nullability; explicitly declare as @Nullable or @NonNull to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations