Better progressive playback controls of bottom pages #164
Conversation
|
Tested with latests Linux Chromium and Electron OK too. |
xlinbsd
changed the title
xlinbsd
changed the title
|
Do be aware, there are 2 other places in code that the volume slider exists. Its also in videoosd.js and remotecontrol.js. Might not have to touch the videoosd.js one, but the remotecontrol.js is actually used in the second music playback screen. The one where you have your queued playlist along the bottom. |
|
@sparky8251 OK Seen. Thanks |
Keeping more preferences toward essential controls in last. Mostly granular show/hide now I can generalize this modifications into other playback control zones in another pull if you are ok. This one seems a priority from my point of view, my personnal usage.
|
Hello, is the new ordering please anyone ? |
|
I included my modifications of second pull since it is in the same objective to improve control bars |
|
Have any before and after pictures? |
|
@sparky8251 I'll do it |
xlinbsd
changed the title
|
After...
|
|
Before.
|
xlinbsd
changed the title
xlinbsd
changed the title
|
Tested on latest iOS Safari, Lineage 16, macos 13's Safari, Linux Firefox && Linux Chromium |
|
It's looking good. Let us know when you feel its "complete". With that, we can properly review it. |
|
I think it is complete for now. Need other users testing (in 10.2.3 ?) the new control style to be sure it is better for majority of us, no ? |
src/bower_components/emby-webcomponents/nowplayingbar/nowplayingbar.css
Outdated
Show resolved
Hide resolved
| @media all and (max-width: 55em) { | ||
|
|
||
| .nowPlayingBarCenter .nextTrackButton, .nowPlayingBarCenter .previousTrackButton, .nowPlayingBarCenter .playPauseButton { | ||
| display: none !important; |
There was a problem hiding this comment.
did you try without the !important? can't see to find more classes that use this sub classes with a display none important.
Also, nowPlayingBarCenter is parent of some of those classes. Try removing all sub classes of this one.
There was a problem hiding this comment.
forget that last part, you are applying the rules to the sub classes, not the parent one.
There was a problem hiding this comment.
I never myself use !important. That is a residue of the old code. I'll try without, it is a good idea.
| @@ -56,7 +56,7 @@ define(['require', 'datetime', 'itemHelper', 'events', 'browser', 'imageLoader', | |||
|
|
|||
| html += '<button is="paper-icon-button-light" class="muteButton mediaButton"><i class="md-icon"></i></button>'; | |||
|
|
|||
| html += '<div class="sliderContainer nowPlayingBarVolumeSliderContainer hide" style="width:100px;vertical-align:middle;display:inline-flex;">'; | |||
| html += '<div class="sliderContainer nowPlayingBarVolumeSliderContainer hide" style="width:150px;vertical-align:middle;display:inline-flex;">'; | |||
There was a problem hiding this comment.
I really don't like !important. could that be because of this inline style? display inline-flex? perhaps moving this rules to nowplayingbar.css will ease the !important? i could be asking too much already
There was a problem hiding this comment.
I will check if !important is really important.
There was a problem hiding this comment.
After some tests, !important is needed in this state of code. I will check why
|
Sorry for the last pushes, I was editing directly in github since I decided to do it right with git commands from my pc. I missed some editings while trying to do things right. |
Better progressive playback controls of bottom pages (#164)
The volume slider is important to conserve at most width for audio playing.
The new value of hiding seems best balanced.
Only tested on last Firefox on Linux. Other tests for a better compromise are welcome.