Volume Slider wider #165
Closed
Volume Slider wider #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Again, the volume slider code is also in videoosd.js and remotecontrol.js. You likely want to make these changes there too. |
|
I'll work on it. |
|
@sparky8251 These js are behavioral scripts. I do not want to change the dynamic side of this control panel for this patch. |
|
Fair enough! I just know that there is a lot of code duplication and just wanted to make sure you were modifying all that needs modifying. Would suck to have your nice changes go in and find out its working a 3rd of the time :) |
|
@xlinbsd why did you close your PR?.. |
|
Hi, I rebranched these modifications into the #164 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since my first patch reorder disapearance of widgets, it is now possible to give more room to control volume that is more usable, especially with touch devices.