Remove filter from library collection type options #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvium
force-pushed
the
fix_library_content_type
branch
from
e06d0ca to
a04ba7b
Compare
JustAMan
approved these changes
Jan 19, 2019
hawken93
suggested changes
Jan 19, 2019
| @@ -42,11 +42,9 @@ define(["loading", "dialogHelper", "dom", "jQuery", "components/libraryoptionsed | |||
| } | |||
|
|
|||
| function getCollectionTypeOptionsHtml(collectionTypeOptions) { | |||
| return collectionTypeOptions.filter(function(i) { | |||
| return i.isSelectable | |||
There was a problem hiding this comment.
Should the functionality still exist / can isSelectable end up false? If so I would recommend adding i.isSelectable !== false back in :)
Edit: plus a comment so it doesn't regress again
There was a problem hiding this comment.
I think we can just re-add it then. Right now it's just clutter imo.
joshuaboniface
approved these changes
Jan 20, 2019
Merged
Deploying with
|
| Latest commit: |
f563fce
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://79798108.jf-web.pages.dev |
Deploying jellyfin-web with
|
| Latest commit: |
e96c140
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://624df5e3.jellyfin-web.pages.dev |
| Branch Preview URL: | https://branch-dzvy94k1eo.jellyfin-web.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's never set apparently. And it broke in #27 because it was assumed it would be set. The old implementation only checked specifically for
false.