Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove filter from library collection type options #44

Merged
merged 1 commit into from
Jan 20, 2019
Merged

Remove filter from library collection type options #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/components/medialibrarycreator/medialibrarycreator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,9 @@ define(["loading", "dialogHelper", "dom", "jQuery", "components/libraryoptionsed
}

function getCollectionTypeOptionsHtml(collectionTypeOptions) {
return collectionTypeOptions.filter(function(i) {
return i.isSelectable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the functionality still exist / can isSelectable end up false? If so I would recommend adding i.isSelectable !== false back in :)
Edit: plus a comment so it doesn't regress again

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can just re-add it then. Right now it's just clutter imo.

}).map(function(i) {
return '<option value="' + i.value + '">' + i.name + "</option>"
}).join("")
return collectionTypeOptions.map(function(i) {
return '<option value="' + i.value + '">' + i.name + "</option>";
}).join("");
}

function initEditor(page, collectionTypeOptions) {
Expand Down