Activate the benchmark profile directly rather than indirectly via a property #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
do not be scared of profiles - activate them directly so you know what is happening (also removed in plugin-pom 4.0) jenkinsci/plugin-pom#269
vars/runBenchmarks.groovy
Outdated
| @@ -14,7 +14,7 @@ def call(String artifacts = null) { | |||
| } | |||
|
|
|||
| stage('Run Benchmarks') { | |||
| List<String> mvnOptions = ['test', '-Dbenchmark'] | |||
| List<String> mvnOptions = ['test', '-P jmh-benchmark'] | |||
There was a problem hiding this comment.
will it work with a space?
There was a problem hiding this comment.
I would expect it is all going down via bash so likely yes - but I have fixed it as it should be a separate arg :)
jetersen
previously approved these changes
Dec 23, 2019
jetersen
approved these changes
Dec 23, 2019
oleg-nenashev
changed the title
oleg-nenashev
approved these changes
Dec 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
do not be scared of profiles - activate them directly so you know what is happening (also removed in plugin-pom 4.0)
jenkinsci/plugin-pom#269