Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activate the benchmark profile directly rather than indirectly via a property #124

Merged
merged 2 commits into from
Dec 23, 2019
Merged

Activate the benchmark profile directly rather than indirectly via a property #124

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88bcc77
activate the profile directly rather than indirectly via a property
jtnord Dec 23, 2019
bf68549
options are different args
jtnord Dec 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion vars/runBenchmarks.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ def call(String artifacts = null) {
}

stage('Run Benchmarks') {
List<String> mvnOptions = ['test', '-Dbenchmark']
List<String> mvnOptions = ['test', '-P jmh-benchmark']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will it work with a space?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect it is all going down via bash so likely yes - but I have fixed it as it should be a separate arg :)

infra.runMaven(mvnOptions)
}

Expand Down