feat: support for generated secrets in schemas #4347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jun 20, 2019
pkg/util/secrets/secrets.go
Outdated
| allowRepeat = true | ||
| ) | ||
|
|
||
| // Generate a secret using sensible defaults |
There was a problem hiding this comment.
comment on exported function DefaultGenerateSecret should be of the form "DefaultGenerateSecret ..."
pmuir
force-pushed
the
step_create_values1
branch
2 times, most recently
from
b5b8f31 to
b7f7583
Compare
Codecov Report
@@ Coverage Diff @@
## master #4347 +/- ##
=========================================
Coverage ? 31.17%
=========================================
Files ? 688
Lines ? 90588
Branches ? 0
=========================================
Hits ? 28243
Misses ? 60945
Partials ? 1400
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #4347 +/- ##
==========================================
- Coverage 31.18% 31.18% -0.01%
==========================================
Files 687 688 +1
Lines 90565 90585 +20
==========================================
Hits 28245 28245
- Misses 60921 60941 +20
Partials 1399 1399
Continue to review full report at Codecov.
|
pmuir
force-pushed
the
step_create_values1
branch
from
b7f7583 to
28a4d7c
Compare
If `"default":"<generated>”` is used on a token or a password then it will default to a generated secret Signed-off-by: Pete Muir <pmuir@bleepbleep.org.uk>
pmuir
force-pushed
the
step_create_values1
branch
from
28a4d7c to
ccd9b67
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jstrachan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
pmuir
added a commit
to pmuir/jx
that referenced
this pull request
Jun 20, 2019
If `"default":"<generated>”` is used on a token or a password then it will default to a generated secret Signed-off-by: Pete Muir <pmuir@bleepbleep.org.uk>
pmuir
added a commit
to pmuir/jx
that referenced
this pull request
Jun 20, 2019
If `"default":"<generated>”` is used on a token or a password then it will default to a generated secret Signed-off-by: Pete Muir <pmuir@bleepbleep.org.uk>
pmuir
added a commit
to pmuir/jx
that referenced
this pull request
Jun 20, 2019
If `"default":"<generated>”` is used on a token or a password then it will default to a generated secret Signed-off-by: Pete Muir <pmuir@bleepbleep.org.uk>
pmuir
added a commit
to pmuir/jx
that referenced
this pull request
Jun 21, 2019
If `"default":"<generated>”` is used on a token or a password then it will default to a generated secret Signed-off-by: Pete Muir <pmuir@bleepbleep.org.uk>
pmuir
added a commit
to pmuir/jx
that referenced
this pull request
Jun 21, 2019
If `"default":"<generated>”` is used on a token or a password then it will default to a generated secret Signed-off-by: Pete Muir <pmuir@bleepbleep.org.uk>
jenkins-x-bot
pushed a commit
that referenced
this pull request
Jun 21, 2019
daveconde
pushed a commit
to daveconde/jx
that referenced
this pull request
Apr 7, 2020
If `"default":"<generated>”` is used on a token or a password then it will default to a generated secret Signed-off-by: Pete Muir <pmuir@bleepbleep.org.uk>
daveconde
pushed a commit
to daveconde/jx
that referenced
this pull request
Apr 7, 2020
…ins-x#4360) If `"default":"<generated>”` is used on a token or a password then it will default to a generated secret Signed-off-by: Pete Muir <pmuir@bleepbleep.org.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitter checklist
Description
feat: support for generated secrets in schemas
If
"default":"<generated>”is used on a token or a password then it will default to a generated secretSigned-off-by: Pete Muir pmuir@bleepbleep.org.uk
Special notes for the reviewer(s)
Which issue this PR fixes
#4328