feat: support looking for existing secrets in vault

[pmuir]

Submitter checklist

• Change is code complete and matches issue description.
• Change is covered by existing or new tests.

Description

If a secret already exists in vault then it is used and not reprompted

Signed-off-by: Pete Muir pmuir@bleepbleep.org.uk

Special notes for the reviewer(s)

Which issue this PR fixes

#4328

[pmuir]

/retest

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@921163c). Click here to learn what that means.
The diff coverage is 73.52%.

@@            Coverage Diff            @@
##             master    #4360   +/-   ##
=========================================
  Coverage          ?   43.36%           
=========================================
  Files             ?      810           
  Lines             ?   101113           
  Branches          ?        0           
=========================================
  Hits              ?    43846           
  Misses            ?    53606           
  Partials          ?     3661

Flag	Coverage Δ
#e2e	31.17% <0%> (?)
#integration	41.7% <73.52%> (?)

Impacted Files	Coverage Δ
pkg/vault/fake/client.go	19.64% <22.22%> (ø)
pkg/surveyutils/jsonschema.go	59.29% <92%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 921163c...d1c6970. Read the comment docs.

[codecov]

Codecov Report

Merging #4360 into master will increase coverage by 1.4%.
The diff coverage is 75.55%.

@@            Coverage Diff            @@
##           master    #4360     +/-   ##
=========================================
+ Coverage   41.94%   43.34%   +1.4%     
=========================================
  Files         810      810             
  Lines      101158   101165      +7     
=========================================
+ Hits        42427    43855   +1428     
+ Misses      55369    53649   -1720     
- Partials     3362     3661    +299

Flag	Coverage Δ
#e2e	31.16% <0%> (+24.52%)	⬆️
#integration	41.69% <75.55%> (ø)	⬆️

Impacted Files	Coverage Δ
pkg/vault/fake/client.go	21.05% <22.22%> (ø)	⬆️
pkg/surveyutils/jsonschema.go	59.77% <88.88%> (+1.32%)	⬆️
pkg/cmd/opts/install.go	8.42% <0%> (+0.33%)	⬆️
pkg/helm/helm_helpers.go	55.13% <0%> (+0.62%)	⬆️
pkg/cmd/opts/helm.go	21.96% <0%> (+0.99%)	⬆️
pkg/cmd/opts/commands.go	35.8% <0%> (+1.23%)	⬆️
pkg/kube/pod.go	23.12% <0%> (+1.36%)	⬆️
pkg/cmd/opts/import.go	37.14% <0%> (+1.42%)	⬆️
pkg/util/strings.go	72.03% <0%> (+1.69%)	⬆️
pkg/cmd/opts/domain.go	20.68% <0%> (+1.72%)	⬆️
... and 48 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 921163c...d1c6970. Read the comment docs.

[jstrachan]

/lgtm

[jenkins-x-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstrachan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jstrachan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment