Fix version of jdk for cd.yaml #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
oleg-nenashev
approved these changes
Apr 7, 2021
jglick
reviewed
Apr 7, 2021
| @@ -50,7 +50,7 @@ jobs: | |||
| uses: actions/setup-java@v2 | |||
| with: | |||
| distribution: 'adopt' | |||
| java-version: 1.8 | |||
| java-version: 8 | |||
There was a problem hiding this comment.
Does this work BTW, or do you need
java-version: '8'to force the value to be treated as a string?
There was a problem hiding this comment.
looks like this worked jenkinsci/jenkins-test-harness@0f4bb0c
There was a problem hiding this comment.
Yes, it did. (There was a probably unrelated problem, what looks like a race condition after merging two PRs in quick succession: Release Drafter wound up including the second PR in the first release’s notes as well as the second’s.)
There was a problem hiding this comment.
I had that happen recently as well
jglick
added a commit
to jenkinsci/jenkins-test-harness
that referenced
this pull request
Apr 7, 2021
jglick
added a commit
to jenkinsci/file-parameters-plugin
that referenced
this pull request
Apr 13, 2021
This was referenced Apr 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jenkinsci/github-admins