Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix version of jdk for cd.yaml #50

Merged
merged 1 commit into from
Apr 7, 2021
Merged

Fix version of jdk for cd.yaml #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion workflow-templates/cd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ jobs:
uses: actions/setup-java@v2
with:
distribution: 'adopt'
java-version: 1.8
java-version: 8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work BTW, or do you need

java-version: '8'

to force the value to be treated as a string?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this worked jenkinsci/jenkins-test-harness@0f4bb0c

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it did. (There was a probably unrelated problem, what looks like a race condition after merging two PRs in quick succession: Release Drafter wound up including the second PR in the first release’s notes as well as the second’s.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had that happen recently as well

- name: Release
uses: jenkins-infra/jenkins-maven-cd-action@v1.1.0
with:
Expand Down