Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize to Jenkins 2.440.3 #291

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

sghill-rewrite
Copy link
Contributor

Hi!

This PR aims to move this plugin to the recommended Jenkins baseline version.

If there are additional requirements for accepting PRs - such as additional lag time before adopting a baseline - feel free to reply in the comments.

Testing done

Ran mvn clean verify.

Submitter checklist

Preview Give feedback

Refs: sghill-rewrite/campaigns#4

Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.jenkins.ModernizePlugin?organizationId=SmVua2lucyBDSQ%3D%3D

@sghill-rewrite sghill-rewrite requested a review from a team as a code owner August 7, 2024 05:38
@dblock
Copy link
Member

dblock commented Aug 7, 2024

Does this increment the minimal version of Jenkins required? Any reason not to merge it?

@sghill
Copy link

sghill commented Aug 7, 2024

It does increase the required Jenkins version to 2.440.3 (released April 2024). Users on older versions of Jenkins would only be able to install earlier versions of this plugin.

Some folks have a preference to wait longer. Personally I think supporting the last couple LTS releases (as this PR does) makes sense. There are important fixes happening all the time in Jenkins, and the longer users wait to upgrade, the harder the upgrade becomes.

Hope that helps. If you have other preferences I'm happy to record them so the tooling won't bug you again with an unwanted upgrade.

@dblock
Copy link
Member

dblock commented Aug 8, 2024

April feels recent, but what versions are LTS?

@sghill
Copy link

sghill commented Aug 8, 2024

The weekly releases all have 2 components (2.440). Once one is chosen to be a LTS, it gets a patch component (2.440.1). There are 3-4 LTS patches before support is dropped and a new weekly release becomes LTS.

The change log is here: https://www.jenkins.io/changelog-stable/

@dblock dblock merged commit e3e6f4a into jenkinsci:master Aug 12, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants