Skip to content

Commit

Permalink
Do not set the JTH War file (#3232)
Browse files Browse the repository at this point in the history
as mentioned in the upstream PR that attempted to do this
unconditionally this is broken by design.

the JTH and tests assume that the classpath is correctly setup however
it is not, as demonstrated in the prior commit.

According to Jenkins there is a plugin installed (trilead-api) because
it is in the megawar, however its classess are not in the flat classpath
used by JenkinsRule and thus breakage ensues.

There are also issues where a plugin is present that is incompatable
with a mode of running for the test - e.g. a system property is set when
running JTH to test a mode of running for a plugin (e.g. FIPS) and the
plugin itself is incompatable with that mode (which causes a
BootFailure).

ref: jenkinsci/plugin-compat-tester#470 (comment)
fixes: #3231
  • Loading branch information
jtnord committed May 29, 2024
1 parent fd1dd45 commit 22daa53
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion pct.sh
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ exec java \
--working-dir "$(pwd)/target/pct-work" \
$PCT_D_ARGS \
${PCT_OPTS-} \
-Djth.jenkins-war.path="$(pwd)/target/megawar-$LINE.war" \
-Dsurefire.excludesFile="$(pwd)/excludes.txt"

# produces: **/target/surefire-reports/TEST-*.xml

0 comments on commit 22daa53

Please sign in to comment.