Set jth.jenkins-war.path unconditionally when running tests
#470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this causes a large amount of test failures as the megawar we use for testing is actually our product war which also contains other things - its not just on top of that there are a few other issues, but they may be fallouts of the above. I'm seeing if I can quickly fix the issues, will continue tomorrow morning, however if not I would suggest we close this. |
jtnord
added a commit
to jtnord/bom
that referenced
this pull request
May 22, 2024
as mentioned in the upstream PR that attempted to do this unconditionally this is broken by design. the JTH and tests assume that the classpath is correctly setup however it is not, as demonstrated in the prior commit. According to Jenkins there is a plugin installed (trilead-api) because it is in the megawar, however its classess are not in the flat classpath used by JenkinsRule and thus breakage ensues. ref: jenkinsci/plugin-compat-tester#470 (comment)
jtnord
added a commit
to jtnord/bom
that referenced
this pull request
May 23, 2024
as mentioned in the upstream PR that attempted to do this unconditionally this is broken by design. the JTH and tests assume that the classpath is correctly setup however it is not, as demonstrated in the prior commit. According to Jenkins there is a plugin installed (trilead-api) because it is in the megawar, however its classess are not in the flat classpath used by JenkinsRule and thus breakage ensues. ref: jenkinsci/plugin-compat-tester#470 (comment)
jtnord
added a commit
to jtnord/bom
that referenced
this pull request
May 23, 2024
as mentioned in the upstream PR that attempted to do this unconditionally this is broken by design. the JTH and tests assume that the classpath is correctly setup however it is not, as demonstrated in the prior commit. According to Jenkins there is a plugin installed (trilead-api) because it is in the megawar, however its classess are not in the flat classpath used by JenkinsRule and thus breakage ensues. There are also issues where a plugin is present that is incompatable with a mode of running for the test - e.g. a system property is set when running JTH to test a mode of running for a plugin (e.g. FIPS) and the plugin itself is incompatable with that mode (which causes a BootFailure). ref: jenkinsci/plugin-compat-tester#470 (comment) fixes: jenkinsci#3231
6 tasks
MarkEWaite
pushed a commit
to jenkinsci/bom
that referenced
this pull request
May 29, 2024
as mentioned in the upstream PR that attempted to do this unconditionally this is broken by design. the JTH and tests assume that the classpath is correctly setup however it is not, as demonstrated in the prior commit. According to Jenkins there is a plugin installed (trilead-api) because it is in the megawar, however its classess are not in the flat classpath used by JenkinsRule and thus breakage ensues. There are also issues where a plugin is present that is incompatable with a mode of running for the test - e.g. a system property is set when running JTH to test a mode of running for a plugin (e.g. FIPS) and the plugin itself is incompatable with that mode (which causes a BootFailure). ref: jenkinsci/plugin-compat-tester#470 (comment) fixes: #3231
jglick
pushed a commit
to jenkinsci/bom
that referenced
this pull request
May 29, 2024
* Introduce EdDSA-api plugin * Do not set the JTH War file as mentioned in the upstream PR that attempted to do this unconditionally this is broken by design. the JTH and tests assume that the classpath is correctly setup however it is not, as demonstrated in the prior commit. According to Jenkins there is a plugin installed (trilead-api) because it is in the megawar, however its classess are not in the flat classpath used by JenkinsRule and thus breakage ensues. ref: jenkinsci/plugin-compat-tester#470 (comment) --------- Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moves #468 onto an origin branch.