Add Lockable Resources to the managed set #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basil
force-pushed
the
lockable-resources
branch
from
41eaf27
to
5c90b7c
Compare
basil
force-pushed
the
lockable-resources
branch
from
5c90b7c
to
bc27b54
Compare
|
Is this ready for review? |
jglick
reviewed
Dec 17, 2021
basil
force-pushed
the
lockable-resources
branch
from
bc27b54
to
fe73b51
Compare
jglick
approved these changes
Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't feel particularly strongly about including this in the BOM, but if tests pass and it improves compatibility testing for a moderately popular plugin, why not?