Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Java 11 and Jenkins 2.361.4 or newer #126

Merged
merged 20 commits into from
Nov 19, 2023
Merged

Require Java 11 and Jenkins 2.361.4 or newer #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
7fc9a86
Update project configuration
alecharp May 17, 2022
6272281
Upgrade project to latest Jenkins version
mat128 Oct 17, 2022
8e4931d
Remove assertions that depend on undeclared parameters
MarkEWaite Oct 23, 2023
6203cf5
Require Java 11 and Jenkins 2.361.4 or newer
MarkEWaite Oct 23, 2023
029c07e
Use parent pom 4.74
MarkEWaite Oct 23, 2023
75694bd
Use parent pom spotbugs, not outdated findbugs
MarkEWaite Oct 23, 2023
8edb7a5
Remove dead local store
MarkEWaite Oct 23, 2023
3c8d32d
Add more spotbugs exclusions
MarkEWaite Oct 23, 2023
89db75c
Declare a string as final to satisfy checkstyle
MarkEWaite Oct 23, 2023
8bd8144
Use https:// instead of git:// in scm property
MarkEWaite Oct 23, 2023
38714c1
Resolve checkstyle complaints in FormValidations
MarkEWaite Oct 23, 2023
adf22cd
Use checkstyle 3.3.0
MarkEWaite Oct 23, 2023
c9fbc52
Exclude generated sources from checkstyle checks
MarkEWaite Oct 23, 2023
9ec7bbd
Silence checkstyle warning about space
MarkEWaite Oct 23, 2023
c88e62b
Add javadoc to satisfy checkstyle
MarkEWaite Oct 23, 2023
aaefd4a
Declare some strings final to satisfy checkstyle
MarkEWaite Oct 23, 2023
b8bcde7
Wrap the line to satisfy checkstyle
MarkEWaite Oct 23, 2023
fab21d6
Remove pmd - not helpful
MarkEWaite Oct 23, 2023
b6e98a8
Do not test with Java 17
MarkEWaite Oct 23, 2023
c311eba
Add icons from @yoavain-sundaysky
MarkEWaite Oct 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Jenkinsfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
#!/usr/bin/env groovy

/* `buildPlugin` step provided by: https://github.com/jenkins-infra/pipeline-library */
buildPlugin()
buildPlugin(configurations: [
[ platform: 'linux', jdk: '11' ],
[ platform: 'windows', jdk: '11' ],
// Compilation fails on Java 17
// [ platform: 'linux', jdk: '17' ],
Comment on lines +7 to +8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#133

])
13 changes: 4 additions & 9 deletions checkstyle_rules.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,11 @@
-->
<module name="Checker">
<property name="severity" value="error"/>
<module name="LineLength">
<property name="ignorePattern" value="^ *\* *[^ ]+$"/>
<property name="max" value="140"/>
</module>
<module name="TreeWalker">
<property name="cacheFile" value="checkstyle-cachefile"/>
<property name="tabWidth" value="4"/>
<module name="AvoidStarImport"/>
<module name="ConstantName"/>
Expand All @@ -28,10 +31,6 @@
</module>
<module name="JavadocMethod">
<property name="severity" value="warning"/>
<property name="allowUndeclaredRTE" value="true"/>
<property name="allowThrowsTagsForSubclasses" value="true"/>
<property name="allowMissingPropertyJavadoc" value="true"/>
<property name="allowMissingThrowsTags" value="true"/>
</module>
<module name="JavadocVariable"/>
<module name="JavadocStyle">
Expand All @@ -45,10 +44,6 @@
<property name="tokens" value="LITERAL_CATCH,LITERAL_DO,LITERAL_ELSE,LITERAL_FINALLY,LITERAL_FOR,LITERAL_IF,LITERAL_SWITCH,LITERAL_SYNCHRONIZED,LITERAL_TRY,LITERAL_WHILE"/>
</module>
<module name="OuterTypeNumber"/>
<module name="LineLength">
<property name="ignorePattern" value="^ *\* *[^ ]+$"/>
<property name="max" value="140"/>
</module>
<module name="LocalFinalVariableName"/>
<module name="LocalVariableName"/>
<module name="MemberName"/>
Expand Down
3 changes: 2 additions & 1 deletion checkstyle_suppressions.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@
Eclipse plug-in.
-->
<suppress checks="." files=".*[\\/]grammars[\\/]Generated[a-zA-Z]*\.java"/>
<suppress checks="." files=".*generated-sources.*"/>
<suppress checks="." files=".*[\\/]src[\\/]test[\\/]"/>
<suppress checks="." files=".*[\\/]checkstyle[\\/]gui[\\/]"/>
<suppress checks="ParameterNumberCheck" files="BuildPipelineView.java"/>
</suppressions>
</suppressions>
6 changes: 0 additions & 6 deletions findbugs-exclude.xml
View file
Open in desktop

This file was deleted.

238 changes: 0 additions & 238 deletions pmd_rules.xml
View file
Open in desktop

This file was deleted.

Loading